Bug 252384 - games/lolcat: Update to latest git commit a1dfac8
Summary: games/lolcat: Update to latest git commit a1dfac8
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-ports-bugs (Nobody)
URL: https://github.com/jaseg/lolcat/commi...
Keywords: buildisok
Depends on:
Blocks:
 
Reported: 2021-01-03 14:43 UTC by Gordon Bergling
Modified: 2021-01-03 19:04 UTC (History)
2 users (show)

See Also:

Attachments
patch for games/lolcat (1.42 KB, application/mbox)
2021-01-03 14:43 UTC, Gordon Bergling 		gbe: maintainer-approval+
Details
Additional improvements in port Makefile (1.13 KB, patch)
2021-01-03 18:09 UTC, Fernando Apesteguía 		gbe: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gordon Bergling freebsd_committer freebsd_triage 2021-01-03 14:43:27 UTC 
Created attachment 221244 [details]
patch for games/lolcat

The attached patch updates games/lolcat to the latest git commit.
Comment 1 Automation User 2021-01-03 14:52:47 UTC 
Build and package info is available at https://gitlab.com/swills/freebsd-ports/pipelines/236764104
Comment 2 Fernando Apesteguía freebsd_committer freebsd_triage 2021-01-03 17:46:46 UTC 
^Triage: Reporter is committer, assign accordingly.

^Triage: Please set the maintainer-approval attachment flag (to +) on patches for ports you maintain to signify approval.
--
Attachment -> Details -> maintainer-approval [+]
Comment 3 Gordon Bergling freebsd_committer freebsd_triage 2021-01-03 17:51:03 UTC 
Comment on attachment 221244 [details]
patch for games/lolcat

Set maintainer approval.
Comment 4 Gordon Bergling freebsd_committer freebsd_triage 2021-01-03 17:52:11 UTC 
Remove myself as assignee since I don't have a ports-bit.
Comment 5 Fernando Apesteguía freebsd_committer freebsd_triage 2021-01-03 18:09:12 UTC 
Created attachment 221248 [details]
Additional improvements in port Makefile

(In reply to Gordon Bergling from comment #4)
Comment 6 Fernando Apesteguía freebsd_committer freebsd_triage 2021-01-03 18:11:26 UTC 
(In reply to Gordon Bergling from comment #4)
Hi Gordon,

Any committer may commit to any repository with an accepted review from any committer with existing access to that repository.

Committers may obtain review via a Differential in Phabricator, adding the "Contributor Reviewers ($Repository)" group as a Reviewer, reaching out to other committers; directly or via mailing lists, or setting the attachment flag to: maintainer-approval ? <person-youd-like-to-review>

I uploaded a new patch that reorders some variables that where out of place.

This builds fine in {11.4,12.2}{amd64,i386} and 13-current amd64. It also runs fine in 12.2amd64.

You can go ahead and commit this by yourself using "Approved by: fernape@" or I can do it for you should you feel more comfortable with the latter.

Cheers!
Comment 7 Gordon Bergling freebsd_committer freebsd_triage 2021-01-03 18:51:47 UTC 
Comment on attachment 221248 [details]
Additional improvements in port Makefile

Thanks for reworking the patch. I had overlooked the DISTVERSION change. I also verified the build on arm64.
Comment 8 Gordon Bergling freebsd_committer freebsd_triage 2021-01-03 18:55:43 UTC 
(In reply to Fernando Apesteguía from comment #6)

Hi Fernando,

thanks for reworking the patch. I wasn't aware of the process within Bugzilla regarding port updates. For larger changes I'll use Phabricator like you suggested.

Please commit the update since I didn't have a commit-ready ports tree checked out at the moment.

Thanks and cheers,

--Gordon
Comment 9 commit-hook freebsd_committer freebsd_triage 2021-01-03 19:03:23 UTC 
A commit references this bug:

Author: fernape
Date: Sun Jan  3 19:02:45 UTC 2021
New revision: 560031
URL: https://svnweb.freebsd.org/changeset/ports/560031

Log:
  games/lolcat: Update to latest git commit a1dfac8

  ChangeLog: https://github.com/jaseg/lolcat/commit/a1dfac8cf45decc99d1a0f6f86a52f65baf96506

  While here, pet linters.

  PR:	252384
  Submitted by:	gbe@FreeBSD.org

Changes:
  head/games/lolcat/Makefile
  head/games/lolcat/distinfo
Comment 10 Fernando Apesteguía freebsd_committer freebsd_triage 2021-01-03 19:04:58 UTC 
Committed,

Thanks!