Created attachment 221251 [details] py-svgwrite-1.4.patch Hi, attached is the patch that updates graphics/py-svgwrite to 1.4. Changes to the port: ~~~~~~~~~~~~~~~~~~~~ * Add location to LICENSE_FILE * Add "do-test" target to make future QA easier. * Add NO_ARCH as the package doesn't contain architecture specific files * Simply workaround for concurrent safety by removing EXAMPLESDIR and adding the keyword "concurrent" instead. * Improve pkg-descr to give some hints about the features of the library. QA: ~~~ - poudriere -> OK (11.4-RELEASE amd64 for each py36, py37, py38 and py39 flavor) Results of "make test": ~~~~~~~~~~~~~~~~~~~~~~~ > 476 passed in N.NN seconds
Looks good to me.
Comment on attachment 221251 [details] py-svgwrite-1.4.patch ^ Triage: Set maintainer-approval flag to '+' according to the feedback given in comment #1.
A commit references this bug: Author: kai Date: Mon Jan 4 09:20:13 UTC 2021 New revision: 560274 URL: https://svnweb.freebsd.org/changeset/ports/560274 Log: graphics/py-svgwrite: Update to 1.4 * Add NO_ARCH as the package doesn't contain architecture specific files. * Simplify concurrent safety handling for the EXAMPLES option. * Add "do-test" target to make future QA easier. * Improve pkg-descr to give some hints about the features of the library. Changelog: https://github.com/mozman/svgwrite/blob/v1.4/NEWS.rst PR: 252389 Approved by: george@m5p.com (maintainer) Changes: head/graphics/py-svgwrite/Makefile head/graphics/py-svgwrite/distinfo head/graphics/py-svgwrite/pkg-descr
(In reply to george from comment #1) Committed, thank you for your fast feedback!
I could swear I set the maintainer-feedback at the same time I wrote comment 1, but apparently I don't understand bugzilla as well as I thought I do
(In reply to george from comment #5) Don't worry, you did that accordingly. ;-) I only set the maintainer-approval flag (not to be confused with the maintainer-feedback flag) as well to signify your approval on the attached patch. In a nutshell: - The maintainer-feedback is set to signify that one has given feedback as maintainer. This avoids maintainer-timeouts. - The maintainer-approval flag, on the other hand, is used to give an approval to one or more patches as an maintainer. The maintainer-approval flag can be set via -> Attachment -> Details -> maintainer-approval [+] . Have also a look at the Bugzilla cheatsheet at the FreeBSD Wiki for further info: https://wiki.freebsd.org/Bugzilla/DosAndDonts
Thanks for the pointer. It's the first time I've ever had to set the maintainer-approval flag (as if you hadn't guessed) and I don't think I would have found it in a million years in the normal course of events. I appreciate the help!