Bug 252476 - multimedia/obs-studio: make sndio optional
Summary: multimedia/obs-studio: make sndio optional
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-01-06 18:17 UTC by Steve Wills
Modified: 2021-01-06 19:54 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (yuri)

Attachments
patch to make sndio optional (5.07 KB, patch)
2021-01-06 18:17 UTC, Steve Wills 		swills: maintainer-approval? (yuri)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Wills freebsd_committer freebsd_triage 2021-01-06 18:17:47 UTC 
Created attachment 221332 [details]
patch to make sndio optional
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2021-01-06 18:50:58 UTC 
Hi Steve,

Thanks for the patch.

This is a cmake-based project so the line

> SNDIO_CONFIGURE_ENABLE=	sndio

is wrong.

But no worries, I will fix this, and will also add options for other audio backends.


Yuri
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2021-01-06 19:15:09 UTC 
Pending the upstream bug report: https://github.com/obsproject/obs-studio/issues/4025
Comment 3 Steve Wills freebsd_committer freebsd_triage 2021-01-06 19:24:46 UTC 
(In reply to Yuri Victorovich from comment #1)
I would rather get the sndio option in now and get the other options later if possible.
Comment 4 Yuri Victorovich freebsd_committer freebsd_triage 2021-01-06 19:54:21 UTC 
Audio backend options are added.

Thanks!
Comment 5 commit-hook freebsd_committer freebsd_triage 2021-01-06 19:54:56 UTC 
A commit references this bug:

Author: yuri
Date: Wed Jan  6 19:54:12 UTC 2021
New revision: 560559
URL: https://svnweb.freebsd.org/changeset/ports/560559

Log:
  multimedia/obs-studio: Optionalize audio backends

  PR:		252476
  Submitted by:	swills (original version for SNDIO)

Changes:
  head/multimedia/obs-studio/Makefile
  head/multimedia/obs-studio/files/patch-UI_window-basic-preview.cpp
  head/multimedia/obs-studio/pkg-plist