Bug 253111 - lang/crystal: Update to 0.36.1
Summary: lang/crystal: Update to 0.36.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Many People
Assignee: Fernando Apesteguía
URL: https://github.com/crystal-lang/cryst...
Keywords: needs-patch, needs-qa
Depends on:
Blocks:
 
Reported: 2021-01-31 00:25 UTC by rlwestlund
Modified: 2021-02-12 11:21 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (val)
fernape: merge-quarterly+

Attachments
crystal0361.patch (53.19 KB, patch)
2021-02-11 14:25 UTC, Val Packett 		val: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description rlwestlund 2021-01-31 00:25:28 UTC 
Crystal version 0.36 has been released. This update is particularly important as I believe it resolves this bug which made Crystal 0.35.1 unusable on FreeBSD: https://github.com/crystal-lang/crystal/pull/10259
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2021-02-10 09:56:42 UTC 
^Triage: 0.36.1 is out upstream
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2021-02-10 10:00:48 UTC 
Note: 0.36.0 includes several "breaking" changes. These may be irrelevant if the existing versions in latest/quarterly deadlock or are otherwise *entirely* unusable.

@Reporter Can you advise on this being merged to quarterly? If they are effectively broken for everyone, then the breaking changes can/should likely be merged wholesale.
Comment 3 rlwestlund 2021-02-10 15:45:57 UTC 
I do believe they are effectively broken for everyone, as in Crystal 0.35.1 on FreeBSD, raising any exception hangs the process.
Comment 4 Val Packett 2021-02-11 14:25:44 UTC 
Created attachment 222366 [details]
crystal0361.patch

Looks like an easy upgrade, still builds with existing bootstrap. Here's the patch.

The issue mentioned above affects *uncaught* exceptions, so only programs that already blow up, blow up in a different way. I have checked that this worked fine on 0.35.1:

begin
raise "error"
rescue
puts "caught"
end

But I think it's fine to include the update in quarterly. It's a rapidly developing language still at 0.x — no stability guarantees yet. Generally no one ever wants an old 0.x of a project like this.
Comment 5 Fernando Apesteguía freebsd_committer freebsd_triage 2021-02-11 14:30:38 UTC 
OK, I'm on it.

Build testing...
Comment 6 commit-hook freebsd_committer freebsd_triage 2021-02-12 11:18:33 UTC 
A commit references this bug:

Author: fernape
Date: Fri Feb 12 11:17:55 UTC 2021
New revision: 565009
URL: https://svnweb.freebsd.org/changeset/ports/565009

Log:
  lang/crystal: Update to 0.36.1

  ChangeLog: https://github.com/crystal-lang/crystal/blob/0.36.1/CHANGELOG.md

  Should fix this issue: https://github.com/crystal-lang/crystal/pull/10259

  PR:	253111
  Submitted by:	rlwestlund@gmail.com
  Approved by:	greg@unrelenting.technology (maintainer)
  MFH:	2021Q1 (runtime fix)

Changes:
  head/lang/crystal/Makefile
  head/lang/crystal/distinfo
  head/lang/crystal/pkg-plist
Comment 7 commit-hook freebsd_committer freebsd_triage 2021-02-12 11:20:34 UTC 
A commit references this bug:

Author: fernape
Date: Fri Feb 12 11:19:36 UTC 2021
New revision: 565010
URL: https://svnweb.freebsd.org/changeset/ports/565010

Log:
  MFH: r565009

  lang/crystal: Update to 0.36.1

  ChangeLog: https://github.com/crystal-lang/crystal/blob/0.36.1/CHANGELOG.md

  Should fix this issue: https://github.com/crystal-lang/crystal/pull/10259

  PR:	253111
  Submitted by:	rlwestlund@gmail.com
  Approved by:	greg@unrelenting.technology (maintainer)

Changes:
_U  branches/2021Q1/
  branches/2021Q1/lang/crystal/Makefile
  branches/2021Q1/lang/crystal/distinfo
  branches/2021Q1/lang/crystal/pkg-plist
Comment 8 Fernando Apesteguía freebsd_committer freebsd_triage 2021-02-12 11:21:02 UTC 
Committed and merged to 2021Q1.

Thanks!