Created attachment 222193 [details] Update to 5.8.1 Update to 5.8.1
Build and package info is available at https://gitlab.com/swills/freebsd-ports/pipelines/252309129
Hi Wen, Thanks for the update. One problem I found :( If option MOTIF is enabled, the build breaks with the following message: [..snip..] Making all in libpolyml /bin/sh ../libtool --tag=CXX --mode=compile c++ -DHAVE_CONFIG_H -I. -I.. -I/usr/local/include -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -Wall -DMODULEDIR=\"/usr/local/lib/polyml/modules\" -isystem /usr/local/include -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -isystem /usr/local/include -MT xwindows.lo -MD -MP -MF .deps/xwindows.Tpo -c -o xwindows.lo xwindows.cpp libtool: compile: c++ -DHAVE_CONFIG_H -I. -I.. -I/usr/local/include -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -Wall -DMODULEDIR=\"/usr/local/lib/polyml/modules\" -isystem /usr/local/include -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -isystem /usr/local/include -MT xwindows.lo -MD -MP -MF .deps/xwindows.Tpo -c xwindows.cpp -fPIC -DPIC -o .libs/xwindows.o xwindows.cpp:7305:43: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Wreserved-user-defined-literal] default: printf("Pointer "ZERO_X"%p",P.AsAddress()); ^ 1 error generated. *** Error code 1 Stop. make[5]: stopped in /poudriere/ports/default/lang/polyml/work/polyml-5.8.1/libpolyml Could you please have a look?
Created attachment 222239 [details] patch with corrections for MOTIF option and sorted Makefile vars I investigated a bit in the MOTIF option and it seems to be solved now :) Because of a typo we need files/patch-libpolyml_xwindows.cpp. Some dependencies for xorg where missing also. Unfortunately, something like MOTIF_USE_XORG seems not to work as expected. I filed a new patch, tested on Poudriere, 'portint -AC' is fine. Could you please have a look at it, especially a the fix for libpolyml/xwindows.cpp, please?
(In reply to Rainer Hurling from comment #3) Build well on my system, please go ahead !
(In reply to Wen Heping from comment #4) Seems we have to wait for maintainer feedback ;) In the meantime, I got approval for my review D28529 on Phabricator from my mentor Glen ...
approved
A commit references this bug: Author: rhurlin Date: Fri Feb 12 11:42:55 UTC 2021 New revision: 565011 URL: https://svnweb.freebsd.org/changeset/ports/565011 Log: lang/polyml: Update to 5.8.1 - Bug fix release for version 5.8 - Visual Studio projects have been updated to VS2017 and SDK 10 Changelog: https://github.com/polyml/polyml/releases/tag/v5.8.1 PR: 253282 Submitted by: Wen Heping <wen@FreeBSD.org> Reviewed by: tcberner (mentor) Approved by: arrowd (mentor) Differential Revision: https://reviews.freebsd.org/D28529 Changes: head/lang/polyml/Makefile head/lang/polyml/distinfo head/lang/polyml/files/patch-libpolyml_polyffi.cpp head/lang/polyml/files/patch-libpolyml_sighandler.cpp head/lang/polyml/files/patch-libpolyml_xwindows.cpp head/lang/polyml/pkg-descr head/lang/polyml/pkg-plist
Committed, thanks :)