Bug 253714 - devel/pycharm-pro: update to 2020.3.4
Summary: devel/pycharm-pro: update to 2020.3.4
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Neel Chauhan
URL: https://confluence.jetbrains.com/disp...
Keywords:
Depends on:
Blocks:
 
Reported: 2021-02-20 09:46 UTC by Guido Kollerie
Modified: 2021-03-20 21:36 UTC (History)
1 user (show)

See Also:


Attachments
svn diff generated patch (79.28 KB, patch)
2021-02-20 09:46 UTC, Guido Kollerie
no flags Details | Diff
svn diff generated patch (80.46 KB, patch)
2021-03-18 07:38 UTC, Guido Kollerie
guido: maintainer-approval+
Details | Diff
svn diff generated patch (80.46 KB, patch)
2021-03-18 07:48 UTC, Guido Kollerie
guido: maintainer-approval+
Details | Diff
Fix for pkg-plist (3.39 KB, patch)
2021-03-20 21:13 UTC, Guido Kollerie
guido: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Guido Kollerie 2021-02-20 09:46:23 UTC
Created attachment 222666 [details]
svn diff generated patch

Update PyCharm Pro to version 2020.3.3.

Additional changes:
- added run dependency on openjfk. This allows certain plugins, that utilize JFX, to work properly.
- copied from java/intellij-ultimate: 
  * enabled fsnotifier (with a note on how to disable it in pkg-message.in)
  * disabled typeAhead (instead of suggesting it in pkg-message.in)
  * disabled java2d.xrender
Comment 1 Neel Chauhan freebsd_committer freebsd_triage 2021-03-10 19:48:15 UTC
Your pkg-plist has these issues:


Error: Orphaned: %%DATADIR%%/bin/idea.vmoptions
Error: Orphaned: %%DATADIR%%/bin/idea64.vmoptions
Error: Orphaned: %%DATADIR%%/plugins/python/helpers/pydev/_pydevd_bundle/pydevd_cython_darwin_38_64.cpython-38-darwin.so
Error: Orphaned: %%DATADIR%%/plugins/python/helpers/pydev/_pydevd_frame_eval/pydevd_frame_evaluator_common.cpython-38-darwin.so
Error: Orphaned: %%DATADIR%%/plugins/python/helpers/pydev/_pydevd_frame_eval/pydevd_frame_evaluator_darwin_38_64.cpython-38-darwin.so
===> Checking for items in pkg-plist which are not in STAGEDIR
Error: Missing: %%DATADIR%%/plugins/python/helpers/pydev/_pydevd_bundle/pydevd_cython_darwin_38_64-darwin.so
Error: Missing: %%DATADIR%%/plugins/python/helpers/pydev/_pydevd_frame_eval/pydevd_frame_evaluator_common-darwin.so
Error: Missing: %%DATADIR%%/plugins/python/helpers/pydev/_pydevd_frame_eval/pydevd_frame_evaluator_darwin_38_64-darwin.so
Comment 2 Guido Kollerie 2021-03-18 07:38:06 UTC
Created attachment 223378 [details]
svn diff generated patch
Comment 3 Guido Kollerie 2021-03-18 07:41:45 UTC
I'm sorry for the pkg-plist issue. I have redone the work in addition to:

- another patch level upgrade of PyCharm 2020.3.3 -> .4
- fixed pty handling by symlinking to `intellij-pty4j` (tested to be working)
Comment 4 Guido Kollerie 2021-03-18 07:48:51 UTC
Created attachment 223379 [details]
svn diff generated patch

Forget to mark the previous patch as obsolete. Didn't know how to do that afterwards. Hence reuploading the patch and marking the previous ones as obsolete
Comment 5 Neel Chauhan freebsd_committer freebsd_triage 2021-03-18 15:54:05 UTC
Committed!
Comment 6 commit-hook freebsd_committer freebsd_triage 2021-03-18 15:54:23 UTC
A commit references this bug:

Author: nc
Date: Thu Mar 18 15:54:01 UTC 2021
New revision: 568746
URL: https://svnweb.freebsd.org/changeset/ports/568746

Log:
  devel/pycharm-pro: update to 2020.3.4

  Changes: https://confluence.jetbrains.com/display/PYH/PyCharm+2020.3.4+Release+Notes

  PR:		253714
  Submitted by:	Guido Kollerie <guido AT kollerie DOT com> (maintainer)

Changes:
  head/devel/pycharm-pro/Makefile
  head/devel/pycharm-pro/distinfo
  head/devel/pycharm-pro/files/pkg-message.in
  head/devel/pycharm-pro/files/pycharm-pro.desktop.in
  head/devel/pycharm-pro/pkg-plist
Comment 7 Guido Kollerie 2021-03-20 21:12:17 UTC
The makeplist generated pkg-plist was still incorrect. This was caused by me having set:

    DEFAULT_VERSIONS+= python=3.8 python3=3.8

in my make.conf. The incorrect pkg-plist caused the build to fail on the FreeBSD package build server:

   http://beefy9.nyi.freebsd.org/data/114amd64-default/568824/logs/pycharm-pro-2020.3.4.log

The attached diff corrects the pkg-plist file. I have tested this to be working by running:

    sudo poudriere testport -j 122amd64 -p development -o devel/pycharm-pro

A test I neglected to do last time. Reason being that, at the time, rust-1.50, a dependency in the long dependency chain, was failing for some reason, preventing me to do the testport run. In retrospect I should have waited to submit my patch.

Anyway things are good now according to poudriere testport. I'm sorry for the inconvenience this has caused.
Comment 8 Guido Kollerie 2021-03-20 21:13:04 UTC
Created attachment 223456 [details]
Fix for pkg-plist
Comment 9 Neel Chauhan freebsd_committer freebsd_triage 2021-03-20 21:36:24 UTC
Committed the fix!
Comment 10 commit-hook freebsd_committer freebsd_triage 2021-03-20 21:36:52 UTC
A commit references this bug:

Author: nc
Date: Sat Mar 20 21:36:22 UTC 2021
New revision: 568886
URL: https://svnweb.freebsd.org/changeset/ports/568886

Log:
  devel/pycharm-pro: Fix pkg-plist

  PR:		253714
  Submitted by:	Guido Kollerie <guido AT kollerie DOT com> (maintainer)

Changes:
  head/devel/pycharm-pro/pkg-plist