Created attachment 222767 [details] Thrift update to 0.13.0 For the upgrade of gitlab-ce to version 13.9.0 I also included an update of the thrift related packages to version 0.13.0. The full diff can be found here: https://gitlab.fechner.net/mfechner/Gitlab/-/compare/master...13.9 The diff that is only related to thrift is attached as patch to this PR. Could you please review the patch and if it is fine, I would commit the update together with the gitlab 13.9.0 upgrade. Thanks.
Just as additional comment, I test build the following packages: # thrift devel/thrift-c_glib devel/thrift-cpp devel/thrift devel/p5-Thrift devel/node-thrift devel/rubygem-thrift devel/py-thrift I was not able to test build devel/thrift-cpp as I use openssl from port and this is marked as broken with the port: https://pkg.fechner.net/build.html?mastername=122amd64-gitlab&build=2021-02-23_21h15m05s https://pkg.fechner.net/data/122amd64-gitlab/2021-02-23_21h15m05s/logs/errors/thrift-cpp-0.13.0,1.log I currently have now a test build running with openssl from ports disabled: https://pkg.fechner.net/build.html?mastername=122amd64-gitlab&build=2021-02-23_21h17m59s But this maybe take some hours to complete. But the main consumer of the rubygem-thrift is gitlab-ce and it is working fine with the new version. If I should test some more packages, please just drop me port and I will include it in the builds.
I did some small plist adaptions to devel/thrift-cpp, now it builds fine: https://gitlab.fechner.net/mfechner/Gitlab/-/commit/18b92cae5f230681001eb517b20efb6f09fd4671
A commit references this bug: Author: mfechner Date: Wed Mar 3 09:25:40 UTC 2021 New revision: 567034 URL: https://svnweb.freebsd.org/changeset/ports/567034 Log: Update thrift ports to 0.13.0 which is required for gitlab-ce upgrade. PR: 253804 Approved by: maintainer timeout Changes: head/devel/node-thrift/pkg-plist head/devel/rubygem-thrift/Makefile head/devel/rubygem-thrift/distinfo head/devel/thrift/Makefile head/devel/thrift/bsd.thrift.mk head/devel/thrift/distinfo head/devel/thrift-cpp/Makefile head/devel/thrift-cpp/pkg-plist
Committed.