Bug 253906 - net/py-wsdd: uppercase LOGIN provision in BEFORE line in rc script
Summary: net/py-wsdd: uppercase LOGIN provision in BEFORE line in rc script
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-02-28 12:35 UTC by Dimitry Andric
Modified: 2023-04-24 20:13 UTC (History)
1 user (show)

See Also:
hiroo.ono+freebsd: maintainer-feedback+
dim: merge-quarterly+

Attachments
Uppercase LOGIN provision in BEFORE: line (880 bytes, patch)
2021-02-28 12:35 UTC, Dimitry Andric 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitry Andric freebsd_committer freebsd_triage 2021-02-28 12:35:53 UTC 
Created attachment 222872 [details]
Uppercase LOGIN provision in BEFORE: line

While experimenting with the new parallel rc loading on recent -CURRENT, I noticed a complaint from rcorder(8) about the wsdd rc script:

% rcorder /etc/rc.d/* /usr/local/etc/rc.d/*
rcorder: file `/usr/local/etc/rc.d/wsdd' is before unknown provision `login'
rcorder: file `/usr/local/etc/rc.d/saslauthd' is before unknown provision `imap'

In the "# BEFORE: login" line, the provision should be uppercased instead, e.g. "LOGIN". This makes the rcorder complaint go away.
Comment 1 Hiroo Ono 2021-02-28 12:49:38 UTC 
Thank you for the patch.
Comment 2 commit-hook freebsd_committer freebsd_triage 2021-02-28 13:02:22 UTC 
A commit references this bug:

Author: dim
Date: Sun Feb 28 13:02:15 UTC 2021
New revision: 566760
URL: https://svnweb.freebsd.org/changeset/ports/566760

Log:
  net/py-wsdd: uppercase LOGIN provision in BEFORE line in rc script

  Avoid complaints from rcorder(8) about "unknown provision `login'". This
  was because the provision 'login' should be uppercased instead.

  Approved by:	hiroo.ono+freebsd@gmail.com (maintainer)
  PR:		253906
  MFH:		2021Q1

Changes:
  head/net/py-wsdd/Makefile
  head/net/py-wsdd/files/patch-etc_rc.d_wsdd
Comment 3 Dimitry Andric freebsd_committer freebsd_triage 2021-02-28 13:09:13 UTC 
Keeping this open until I get approval to merge into 2021Q1.
Comment 4 Hiroo Ono 2022-02-02 11:57:46 UTC 
Maybe this bug can be closed? We are already in 2022.
Comment 5 Dimitry Andric freebsd_committer freebsd_triage 2023-04-24 20:13:31 UTC 
Apologies, I should have closed this long ago :)