Created attachment 223030 [details] update to 1.5.24 ibus recently updated to 1.5.24. Changelog: Features & Bug Fixes: Add GTK4 IM module c7928b1 d0a47c3 Search engine name directly ef4c5c7 Update IBusInputPurpose and IBusInputHints in ibustypes.h b72efea Warn deprecated IBus XKB engines /w dialog 5322c44 Update simple.xml 5012b69 Add CI 30a3641 Fix arguments in GLib.DBusSignalCallback for Vala 0.50 dd4cc5b Fix to build emoji-*.dict in CLDR 38 aa558de Fix build environments 02338ce 5d68b00 29959e1 Code Contributors: Warning dialog for any deprecated IBus XKB engine (Gunnar Hjalmarsson) aec2ac7 Hide IBus Preferences from AppStream (Gunnar Hjalmarsson) 72ca5c9 Translation Updates. Changes: * Since FreeBSD has no gtk4 yet, I've disabled it. * Added WAYLAND option to build wayland support. Not tested. * Updated pkg-message to mention Plasma, and removed ibus-qt. * A patch is integrated.
Created attachment 223031 [details] Poudriere log for 12.2-RELEASE-p2/amd64
Hi Henry, There are many ports (at least 18) that depend directly on textproc/ibus. Have you checked that all continue to build and install with the update? Are there any special problems to be expected? Don't some of the dependent ports (i.e. x11/plasma5-plasma-desktop, devel/efl, ...) need an increase in PORTREVISION because the version of the library has changed (libibus-1.0.so.5.0.523 to libibus-1.0.so.5.0.524)?
(In reply to Rainer Hurling from comment #2) 1. I am not the maintainer of these ports, so I don't think I have to check if all of them build correctly? If they can't build afterwards, we'll get reports from pkg-fallout, and we can fix them. Meanwhile, this is only a minor version bump, and building ibus-pinyin seems to work just fine. 2. I don't see why you think plasma-desktop or efl depends on this one. freshports only shows a small number of ports depend on this one: (from https://www.freshports.org/textproc/ibus) for Build chinese/ibus-chewing chinese/ibus-table-chinese for Libraries chinese/ibus-cangjie chinese/ibus-libpinyin chinese/ibus-pinyin chinese/ibus-rime japanese/ibus-anthy japanese/ibus-mozc japanese/ibus-skk korean/ibus-hangul sysutils/gnome-control-center textproc/ibus-kmfl textproc/ibus-m17n textproc/ibus-table textproc/ibus-typing-booster for Run chinese/ibus-chewing chinese/ibus-pinyin chinese/ibus-table-chinese textproc/ibus-m17n textproc/ibus-uniemoji They don't need to have PORTREVISION bump, because they depend on libibus-1.0.so.5, not the specific minor version: (this is from ibus-pinyin): > ldd /usr/local/libexec/ibus-engine-pinyin /usr/local/libexec/ibus-engine-pinyin: libibus-1.0.so.5 => /usr/local/lib/libibus-1.0.so.5 (0x80026b000) ... The old binary can still work.
(In reply to Henry Hu from comment #3) Hi Henry, I am aware that you are not the maintainer of those depend ports. The submitter (and the committer) of a patch should check all consumer ports to see if they can actually build against the updated port. This should also be done with ports whose dependency is optional and disabled by default. Committers are always happy if the submitter does this himself, since committers usually have to test many different ports and dependencies in the same time ;) In this case with the textproc/ibus dependencies, you are probably right. Since the library major version remains, there are probably no incompatibilities and then no bump of the dependent ports would be necessary. (Hint: Some test builds could check this ;) ) But we should be vigilant and if a problem does occur, we should be able to react together quickly. Is that ok for you? I will have a deeper look at the patch tomorrow.
Created attachment 223099 [details] Makefile with reordered vars, as suggested by portclippy Hi Henry, Your patch builds and installs well on Poudriere (amd64, i836). I reordered some Makefile vars, as suggested by portclippy. In doing so, I also added NO_OPTIONS_SORT, because that's the order of OPTIONS you intend, isn't it? If you agree with these (non-functional) changes, I would commit the patch like this?
(In reply to Rainer Hurling from comment #5) Well the order of the options is not that important. We just add option one by one - so reordering them is fine.
A commit references this bug: Author: rhurlin Date: Tue Mar 9 06:07:51 UTC 2021 New revision: 567891 URL: https://svnweb.freebsd.org/changeset/ports/567891 Log: textproc/ibus: Update to 1.5.24 Changelog: https://github.com/ibus/ibus/releases/tag/1.5.24 PR: 254072 Submitted by: Henry Hu <henry.hu.sh@gmail.com> (maintainer) Changes: head/textproc/ibus/Makefile head/textproc/ibus/distinfo head/textproc/ibus/files/patch-ui_gtk3_application.vala head/textproc/ibus/pkg-message head/textproc/ibus/pkg-plist
Committed, thanks :)