Bug 254243 - deskutils/sysctlview: Update to 2.1
Summary: deskutils/sysctlview: Update to 2.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Rainer Hurling
URL: https://gitlab.com/alfix/sysctlview/-...
Keywords:
Depends on:
Blocks:
 
Reported: 2021-03-12 20:02 UTC by Alfonso S. Siciliano
Modified: 2021-03-13 10:22 UTC (History)
1 user (show)

See Also:


Attachments
svn .diff (2.01 KB, patch)
2021-03-12 20:02 UTC, Alfonso S. Siciliano
asiciliano: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alfonso S. Siciliano freebsd_committer freebsd_triage 2021-03-12 20:02:42 UTC
Created attachment 223219 [details]
svn .diff

sysctlview update 1.2.1 -> 2.1

Testing:

 * portlint -C
 * port test
Comment 1 Alfonso S. Siciliano freebsd_committer freebsd_triage 2021-03-13 01:07:11 UTC
typo:

sysctlview update 2.0.1 -> 2.1
Comment 2 Rainer Hurling freebsd_committer freebsd_triage 2021-03-13 08:45:44 UTC
Hi Alfonso,

I am wondering how NLS_CONFIGURE_ENABLE=nls should work without a configure script? As far as I can see, there is no difference in resulting files concerning the internationalization between build with and build without NLS (gettext) option? In both cases, only the buttons in the About windows are internationalized.

And in case gettext is functional here after all: is there a reason to have gettext twice in the Makefile? I think it would be sufficient to have NLS_USES=gettext (without -runtime). What do you think about this?
Comment 3 Alfonso S. Siciliano freebsd_committer freebsd_triage 2021-03-13 09:35:05 UTC
Hi Rainer,

You are right NLS is not functional, I added NLS to fix a "portlint -C" warning since version 0.1. However I have not a strong opinion about it, feel free to delete it.
Comment 4 commit-hook freebsd_committer freebsd_triage 2021-03-13 10:16:00 UTC
A commit references this bug:

Author: rhurlin
Date: Sat Mar 13 10:15:13 UTC 2021
New revision: 568241
URL: https://svnweb.freebsd.org/changeset/ports/568241

Log:
  deskutils/sysctlview: Update to 2.1

  Changelog: https://gitlab.com/alfix/sysctlview/-/blob/master/CHANGELOG

  PR:		254243
  Submitted by:	Alfonso S. Siciliano <alfix86@gmail.com> (maintainer)

Changes:
  head/deskutils/sysctlview/Makefile
  head/deskutils/sysctlview/distinfo
  head/deskutils/sysctlview/files/
Comment 5 Rainer Hurling freebsd_committer freebsd_triage 2021-03-13 10:22:32 UTC
Committed, thanks :)

Thank you for this nice tool! I was not aware of it before :)

I have removed all the gettext related context for now as it is not currently used. We can add it back very easily if needed.


As a thought for the next update: In the Flags window, the last column 'DYN' is not behaving as expected. When the window is enlarged to the right, the content of this column also moves to the right. A fixed width also for the last column would be nicer in my opinion ;)