Created attachment 223221 [details] fix leftover files in poudriere testport or bulk -t A poudriere testport or poudriere bulk -t fails as shown below. The FreeBSD porter's handbook states that Qt ports do not require INSTALL_ICONS, so I propose to remove it (-> patch). Bumps PORTREVISION at the same time. Error log from poudriere: [00:11:57] Deinstallation has been requested for the following 1 packages (of 0 packages in the universe): [00:11:57] [00:11:57] Installed packages to be REMOVED: [00:11:57] qmmp-qt5: 1.2.0_9 [00:11:57] [00:11:57] Number of packages to be removed: 1 [00:11:57] [00:11:57] The operation will free 10 MiB. [00:11:57] [122amd64-svn-job-03] [1/1] Deinstalling qmmp-qt5-1.2.0_9... [00:11:57] [122amd64-svn-job-03] [1/1] Deleting files for qmmp-qt5-1.2.0_9: .......... done [00:11:58] =========================================================================== [00:11:58] =>> Checking for extra files and directories [00:12:00] =>> Error: Files or directories left over: [00:12:00] share/icons/hicolor/icon-theme.cache
This, by contrast, is the same poudriere command line with the patch applied - no leftover files: [00:03:04] =======================<phase: deinstall >============================ [00:03:04] ===> Deinstalling for qmmp-qt5 [00:03:04] ===> Deinstalling qmmp-qt5-1.2.0_10 [00:03:04] Updating database digests format: .......... done [00:03:04] Checking integrity... done (0 conflicting) [00:03:04] Deinstallation has been requested for the following 1 packages (of 0 packages in the universe): [00:03:04] [00:03:04] Installed packages to be REMOVED: [00:03:04] qmmp-qt5: 1.2.0_10 [00:03:04] [00:03:04] Number of packages to be removed: 1 [00:03:04] [00:03:04] The operation will free 10 MiB. [00:03:04] [122amd64-svn-job-01] [1/1] Deinstalling qmmp-qt5-1.2.0_10... [00:03:04] [122amd64-svn-job-01] [1/1] Deleting files for qmmp-qt5-1.2.0_10: .......... done [00:03:04] =========================================================================== [00:03:04] =>> Checking for extra files and directories [00:03:05] =>> Cleaning up wrkdir [00:03:06] ===> Cleaning for qmmp-qt5-1.2.0_10
^Triage: Reporter is committer, assign accordingly.
maintainer timeout, 16d, liangtai.s16@gmail.com
A commit references this bug: Author: mandree Date: Sun Mar 28 21:09:43 UTC 2021 New revision: 569414 URL: https://svnweb.freebsd.org/changeset/ports/569414 Log: multimedia/qmmp-qt5: fix leftover files Remove INSTALL_ICONS to solve this build issue: [00:11:58] =>> Checking for extra files and directories [00:12:00] =>> Error: Files or directories left over: [00:12:00] share/icons/hicolor/icon-theme.cache INSTALL_ICONS is documented as not required for Qt-based ports. PR: 254245 Submitted by: mandree@ Approved by: maintainer timeout, 16d, liangtai.s16@gmail.com Changes: head/multimedia/qmmp-qt5/Makefile