Bug 254621 - math/R: remove obsolete fpsetmask
Summary: math/R: remove obsolete fpsetmask
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Joseph Mingrone
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-03-28 02:33 UTC by Piotr Kubaj
Modified: 2021-03-28 11:59 UTC (History)
1 user (show)

See Also:
jrm: maintainer-feedback+

Attachments
patch (1.49 KB, patch)
2021-03-28 02:33 UTC, Piotr Kubaj 		pkubaj: maintainer-approval? (jrm)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2021-03-28 02:33:41 UTC 
Created attachment 223657 [details]
patch

src/unix/sys-unix.c uses fpsetmask to workaround a bug that is not present since FreeBSD 4.0.

This issue also affected Firefox and was resolved 9 years ago https://bugzilla.mozilla.org/show_bug.cgi?id=789436#c27

fpsetmask executions cause R build to crash on powerpc64(le), since new SIGFPE kernel code doesn't take into account old workarounds.
Comment 1 Joseph Mingrone freebsd_committer freebsd_triage 2021-03-28 11:20:01 UTC 
Thanks, looks good.
Comment 2 commit-hook freebsd_committer freebsd_triage 2021-03-28 11:59:51 UTC 
A commit references this bug:

Author: pkubaj
Date: Sun Mar 28 11:59:03 UTC 2021
New revision: 569385
URL: https://svnweb.freebsd.org/changeset/ports/569385

Log:
  math/R: remove obsolete fpsetmask

  src/unix/sys-unix.c uses fpsetmask to workaround a bug that is not present since FreeBSD 4.0.

  This issue also affected Firefox and was resolved 9 years ago https://bugzilla.mozilla.org/show_bug.cgi?id=789436#c27

  fpsetmask executions cause R build to crash on powerpc64(le), since new SIGFPE kernel code doesn't take into account old workarounds.

  PR:		254621
  Approved by:	jrm (maintainer)

Changes:
  head/math/R/files/patch-src_unix_sys-unix.c