When DOCS option is on, the build calls 'setup.py build_sphinx'. This error occurs when using python3.6: ==================== . . File "/tmp/pip-20.3.4/docs/docs_feedback_sphinxext.py", line 3 from __future__ import annotations ^ SyntaxError: future feature annotations is not defined ==================== 20.3.4 has a new docs_feedback_sphinxext.py file which has: from __future__ import annotations This fails with python3.6. Workaround: WITHOUT=DOCS for python3.6 The easy change is probably to change USES=python:3.6+ to 3.7+ (this could be dependent on whether DOCS is on but that is probably more trouble than it's worth).
Thank you for the report John. pip declares support for 3.5+ [1], this issue has been reported upstream. Re the easy change in comment 0, Python ports must not set Python support <version-spec> arbitrarily. It is a declarative expression of version support, not an imperative one to use specific versions. [1] '>=2.7,!=3.0.*,!=3.1.*,!=3.2.*,!=3.3.*,!=3.4.*',
(In reply to Kubilay Kocak from comment #1) Yes, I did see that python_requires='>=2.7,!=3.0.*,!=3.1.*,!=3.2.*,!=3.3.*,!=3.4.*' in setup.py and considered that. My [brief] thinking was: We already deviate from the upstream 'requires' spec due to overriding freebsd project concerns, namely: we don't support python2.7 or python3.5 anymore. So that's why the port has USES=python:3.6+ - if we strictly adhered to a regurgitation of the upstream requirement spec, it should have USES=python:2.7,3.5+. But, of course, this case is different since it is not _freebsd_ that chose not to support the older versions, but upstream (although possibly unintentionally) when they added the new requirement without updating 'requires'. The freebsd port chooses to optionally build the documentation (if DOCS is on). Upstream may consider 'build_sphinx' a second class citizen when considering its 'requires'. If so, then it seems it would be okay to set USES=python:3.7+. If not, then I agree it is just an outright upstream bug. I suspect you're right, and they DON'T consider build_sphinx a second class citizen, so the full-on 'bug' moniker would be correct. That said, until they fix upstream, our ports tree is [slightly] broken (especially since DOCS is on by default). So that's the main reason I advocated setting USES=python:3.7+ for now - that can be a reasonable temporary workaround (at least when we build with DOCS). The breakage is pretty minor, however, since the default python version is now > 3.6. Because of that, very few people will hit this bug. If you don't think it's worth our time to commit anything to address the breakage, that's okay with me. I can just close this with a "won't fix" resolution. For now, I'll just let this sit and wait a while to hear from upstream. For reference, here is the upstream issue report (yes, that was from me): https://github.com/pypa/pip/issues/9941 No bites yet.
" we don't support python2.7 or python3.5 anymore. So that's why the port has USES=python:3.6+ " Yep, I understand how this may have seemed to be the case. However, there are no actual overriding project concerns. Excluding python versions by imperatively changing individual version specs, versus another method, either a temporary measure in individual ports or at the framework level, which derived the highest or best Python version to use given a certain <version-spec> was not appropriate and unfortunately set a poor precedent that we need to remedy. The correct resolution here will be one of, upstream fixes the bug, restoring support for the versions they declare support for (ie; its a bug), or version support is updated to reflect the current reality. It's definitely worth our time to fix it.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=86c8db870a52032313dcdabfc0e99974f42255ea commit 86c8db870a52032313dcdabfc0e99974f42255ea Author: Po-Chuan Hsieh <sunpoet@FreeBSD.org> AuthorDate: 2021-05-07 09:27:27 +0000 Commit: Po-Chuan Hsieh <sunpoet@FreeBSD.org> CommitDate: 2021-05-07 09:53:01 +0000 devel/py-pip: Fix build with DOCS option enabled on Python 3.6 PR: 255579 Reported by: John Hein <jcfyecrayz@liamekaens.com> devel/py-pip/Makefile | 9 ++++++++- devel/py-pip/files/extra-patch-python36 (new) | 11 +++++++++++ 2 files changed, 19 insertions(+), 1 deletion(-)
Committed. Thanks!
An upstream issue was filed on this: https://github.com/pypa/pip/issues/9941 but the issue went away in upstream commit 1e2873a, released in pip 21.1 (2021-04-24).