Bug 255713 - ports-mgmt/porttools: update for git
Summary: ports-mgmt/porttools: update for git
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Steven Kreuzer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-08 19:25 UTC by John Hein
Modified: 2021-05-20 11:08 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (skreuzer)


Attachments
[patch] update porttools to chase freebsd ports tree svn->git transition (1.27 KB, patch)
2021-05-08 19:25 UTC, John Hein
no flags Details | Diff
[patch] update porttools to chase freebsd ports tree svn->git transition [v2] (1.38 KB, patch)
2021-05-08 19:34 UTC, John Hein
jcfyecrayz: maintainer-approval? (skreuzer)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Hein 2021-05-08 19:25:34 UTC
Created attachment 224777 [details]
[patch] update porttools to chase freebsd ports tree svn->git transition

The skreuzer porttools repo on upstream github has updates to accomodate the freebsd ports tree switch from svn to git.

Attached is an update for a tentative 1.10 version that includes those changes.  I don't see any way to have a 'pull request' on github.com for just putting a tag in place.  The patch attached references the specific commit id (GH_TAGNAME).  If a 1.10 tag appears in the upstream repo (hint, hint), the GH_TAGNAME in the patch can be removed (and probably re-run 'make makesum').
Comment 1 John Hein 2021-05-08 19:26:34 UTC
Comment on attachment 224777 [details]
[patch] update porttools to chase freebsd ports tree svn->git transition

Steven, if you add a 1.10 tag on github, tweak patch accordingly.
Comment 2 John Hein 2021-05-08 19:34:34 UTC
Created attachment 224778 [details]
[patch] update porttools to chase freebsd ports tree svn->git transition [v2]

Forgot to change run dep from svn to git.
Comment 3 commit-hook freebsd_committer freebsd_triage 2021-05-14 15:44:15 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b8e3cc36b68c00893c39a8ec64c373d87be62c0e

commit b8e3cc36b68c00893c39a8ec64c373d87be62c0e
Author:     Steven Kreuzer <skreuzer@FreeBSD.org>
AuthorDate: 2021-05-14 15:41:49 +0000
Commit:     Steven Kreuzer <skreuzer@FreeBSD.org>
CommitDate: 2021-05-14 15:44:11 +0000

    ports-mgmt/porttools: Update to version 1.10

    Update port to version 1.10, which adds support for working with git repos

    PR:             255713
    Reported by:    John Hein <jcfyecrayz@liamekaens.com>

 ports-mgmt/porttools/Makefile | 5 +++--
 ports-mgmt/porttools/distinfo | 6 +++---
 2 files changed, 6 insertions(+), 5 deletions(-)
Comment 4 Steven Kreuzer freebsd_committer freebsd_triage 2021-05-14 15:44:46 UTC
Committed! Thanks
Comment 5 John Hein 2021-05-15 16:14:47 UTC
(In reply to Steven Kreuzer from comment #4)
Thanks.  Is there any reason not to push a 1.10 tag upstream?
Comment 6 John Hein 2021-05-20 11:08:02 UTC
(In reply to John Hein from comment #5)
It looks like a 1.10 tag was added in github.com (thanks), although it is not an annotated tag, so who knows when it was added.

<side comment>And there's no history tracking if it ever changes (true whether it's annotated or not).  I really hate tags in git  it might even be worse than cvs in many ways as far as lack of history.  You need to write down the commit id out of band to know if a tag changes because there's no way in git of knowing if/when it changes (maybe for a short while before garbage collection removes the ephemeral history of any such change(s)).</side comment>

Anyway, the GH_TAGNAME could be removed (and re-run 'make makesum').  But maybe it's better to just keep the tag info because of git's tag history weakness.  Less thrash in the port, too.  I guess I wouldn't bother removing the GH_TAGNAME.