Bug 255887 - benchmarks/vkmark fails to build on aarch64
Summary: benchmarks/vkmark fails to build on aarch64
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: arm64 Any
: --- Affects Some People
Assignee: Jan Beich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-14 23:17 UTC by Mark Linimon
Modified: 2021-05-15 00:06 UTC (History)
0 users

See Also:
jbeich: maintainer-feedback+
jbeich: merge-quarterly+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Linimon freebsd_committer freebsd_triage 2021-05-14 23:17:39 UTC 
In benchmarks/vkmark/Makefile, we have:

  DRM_BUILD_DEPENDS=${LOCALBASE}/include/vulkan/vulkan_intel.h:graphics/mesa-dri

and yet in graphics/mesa-dri/pkg-plist we have:

  %%INTEL_VDRIVER%%include/vulkan/vulkan_intel.h

and in graphics/mesa-dri/Makefile, we have:

  .if ${ARCH} == aarch64 [...]
  VULKAN_DRIVERS+=        AMD

I have no idea what the proper fix is here (if any).
Comment 1 commit-hook freebsd_committer freebsd_triage 2021-05-14 23:51:46 UTC 
A commit in branch 2021Q2 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c964630d3617a4491a9f3de2658360c58c16bbd1

commit c964630d3617a4491a9f3de2658360c58c16bbd1
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2021-05-14 23:44:31 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2021-05-14 23:51:02 +0000

    benchmarks/vkmark: unbreak on non-x86 after bfcd0e437af3

    ===>   vkmark-2017.08.24 depends on file: /usr/local/include/vulkan/vulkan_intel.h - not found
    *** Error code 1

    PR:             255887
    Reported by:    linimon

    (cherry picked from commit 156537c43a62e8c700865d183cc9f14838ac6fbc)

 benchmarks/vkmark/Makefile | 1 +
 1 file changed, 1 insertion(+)
Comment 2 commit-hook freebsd_committer freebsd_triage 2021-05-14 23:51:47 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=156537c43a62e8c700865d183cc9f14838ac6fbc

commit 156537c43a62e8c700865d183cc9f14838ac6fbc
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2021-05-14 23:44:31 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2021-05-14 23:50:47 +0000

    benchmarks/vkmark: unbreak on non-x86 after bfcd0e437af3

    ===>   vkmark-2017.08.24 depends on file: /usr/local/include/vulkan/vulkan_intel.h - not found
    *** Error code 1

    PR:             255887
    Reported by:    linimon

 benchmarks/vkmark/Makefile | 1 +
 1 file changed, 1 insertion(+)
Comment 3 Jan Beich freebsd_committer freebsd_triage 2021-05-15 00:01:38 UTC 
Thanks. I wish pkg-fallout@ mailed me[1] given aarch64 is Tier1 nowadays. 

[1] https://lists.freebsd.org/pipermail/freebsd-ports/2017-July/109503.html

(In reply to Mark Linimon from comment #0)
>  %%INTEL_VDRIVER%%include/vulkan/vulkan_intel.h

Removed upstream, see ports 116c6c13785b and https://github.com/vkmark/vkmark/issues/33

Mesa 21.1.0 was released on 2021-05-05, so amd64 + i386 are still fine due to x11@ being slow.