Bug 255917 - net-p2p/xmrig: Fix build on aarch64
Summary: net-p2p/xmrig: Fix build on aarch64
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Emanuel Haupt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-16 09:16 UTC by Mikael Urankar
Modified: 2021-05-17 15:30 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (ehaupt)


Attachments
v0 (1.99 KB, patch)
2021-05-16 09:16 UTC, Mikael Urankar
no flags Details | Diff
v1 (1009 bytes, patch)
2021-05-16 13:42 UTC, Mikael Urankar
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mikael Urankar freebsd_committer freebsd_triage 2021-05-16 09:16:53 UTC
Created attachment 224988 [details]
v0

Reported upstream:
https://github.com/xmrig/xmrig/pull/2382
Comment 1 Mikael Urankar freebsd_committer freebsd_triage 2021-05-16 09:36:24 UTC
there is also https://github.com/xmrig/xmrig/pull/2340
Comment 2 Emanuel Haupt freebsd_committer freebsd_triage 2021-05-16 11:44:27 UTC
Hello @mikael, thank you for the aarch64 fix. I have currently no way of testing the patch. If it passes a poudriere build on said arch please feel free to commit.
Comment 3 Mikael Urankar freebsd_committer freebsd_triage 2021-05-16 13:42:08 UTC
Created attachment 224992 [details]
v1

Use upstream version.
Comment 4 commit-hook freebsd_committer freebsd_triage 2021-05-17 15:28:42 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2c7f7c36dcfd4984c83e1fe34dbbb4fbef2a4ace

commit 2c7f7c36dcfd4984c83e1fe34dbbb4fbef2a4ace
Author:     Mikael Urankar <mikael@FreeBSD.org>
AuthorDate: 2021-05-17 15:27:24 +0000
Commit:     Emanuel Haupt <ehaupt@FreeBSD.org>
CommitDate: 2021-05-17 15:27:24 +0000

    net-p2p/xmrig: Fix build on aarch64

    PR:             255917

 net-p2p/xmrig/Makefile | 4 +++-
 net-p2p/xmrig/distinfo | 4 +++-
 2 files changed, 6 insertions(+), 2 deletions(-)
Comment 5 Emanuel Haupt freebsd_committer freebsd_triage 2021-05-17 15:30:02 UTC
Thanks for the new patch. I've also removed the BROKEN_aarch64 line.