Bug 256335 - databases/postgresql12-server rc script comes before cleartmp with changed REQUIRES
Summary: databases/postgresql12-server rc script comes before cleartmp with changed RE...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: pgsql
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-06-01 13:21 UTC by Jeroen Pulles
Modified: 2021-06-01 14:07 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (pgsql)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeroen Pulles 2021-06-01 13:21:49 UTC 
Changeset ab83f2b4bb78a718efa5c43247ba1e1d207f99b6 changed the startup order for Postgresql. The cleartmp rc.d now comes after the Postgresql startup. Unfortunately Postgresql likes to create a socket in /tmp/.s.PGSQL.5432. After cleartmp does its work, that socket disappears from the filesystem.  

The REQUIRE line was changed from sshd to SERVERS. Maybe revert to sshd: As far as I understand rcorder, it does not really matter if sshd is enabled or not. It's in base, so we're sure it always is available for all users. 

I'd like to think that using DAEMON for REQUIRE works fine (it comes after cleartmp).
Comment 1 commit-hook freebsd_committer freebsd_triage 2021-06-01 14:00:20 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8d831eb43aba59013b948830cbd4b22b45deb223

commit 8d831eb43aba59013b948830cbd4b22b45deb223
Author:     Palle Girgensohn <girgen@FreeBSD.org>
AuthorDate: 2021-06-01 13:59:02 +0000
Commit:     Palle Girgensohn <girgen@FreeBSD.org>
CommitDate: 2021-06-01 13:59:35 +0000

    databases/postgresql??-server: rc-script should require DAEMON

    Changeset ab83f2b4bb78 changed the startup order for Postgresql. The cleartmp
    rc.d now comes after the Postgresql startup.  Unfortunately, Postgresql likes
    to create a socket in /tmp/.s.PGSQL.5432. After cleartmp does its work, that
    socket disappears from the filesystem.

    Submitted by:   Jeroen Pulles
    PR:             256335

 databases/postgresql10-server/Makefile            | 2 +-
 databases/postgresql10-server/files/postgresql.in | 2 +-
 databases/postgresql11-server/Makefile            | 2 +-
 databases/postgresql11-server/files/postgresql.in | 2 +-
 databases/postgresql12-server/Makefile            | 2 +-
 databases/postgresql12-server/files/postgresql.in | 2 +-
 databases/postgresql13-server/Makefile            | 2 +-
 databases/postgresql13-server/files/postgresql.in | 2 +-
 databases/postgresql14-server/Makefile            | 2 +-
 databases/postgresql14-server/files/postgresql.in | 2 +-
 databases/postgresql96-server/Makefile            | 2 +-
 databases/postgresql96-server/files/postgresql.in | 2 +-
 12 files changed, 12 insertions(+), 12 deletions(-)
Comment 2 Palle Girgensohn freebsd_committer freebsd_triage 2021-06-01 14:00:39 UTC 
Committed. Thanks!
Comment 3 commit-hook freebsd_committer freebsd_triage 2021-06-01 14:07:23 UTC 
A commit in branch 2021Q2 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=df154b989620e4c84258747601cc678e15dd119e

commit df154b989620e4c84258747601cc678e15dd119e
Author:     Palle Girgensohn <girgen@FreeBSD.org>
AuthorDate: 2021-06-01 13:59:02 +0000
Commit:     Palle Girgensohn <girgen@FreeBSD.org>
CommitDate: 2021-06-01 14:06:02 +0000

    databases/postgresql??-server: rc-script should require DAEMON

    Changeset ab83f2b4bb78 changed the startup order for Postgresql. The cleartmp
    rc.d now comes after the Postgresql startup.  Unfortunately, Postgresql likes
    to create a socket in /tmp/.s.PGSQL.5432. After cleartmp does its work, that
    socket disappears from the filesystem.

    Submitted by:   Jeroen Pulles
    PR:             256335

    (cherry picked from commit 8d831eb43aba59013b948830cbd4b22b45deb223)

 databases/postgresql10-server/Makefile            | 2 +-
 databases/postgresql10-server/files/postgresql.in | 2 +-
 databases/postgresql11-server/Makefile            | 2 +-
 databases/postgresql11-server/files/postgresql.in | 2 +-
 databases/postgresql12-server/Makefile            | 2 +-
 databases/postgresql12-server/files/postgresql.in | 2 +-
 databases/postgresql13-server/Makefile            | 2 +-
 databases/postgresql13-server/files/postgresql.in | 2 +-
 databases/postgresql96-server/Makefile            | 2 +-
 databases/postgresql96-server/files/postgresql.in | 2 +-
 10 files changed, 10 insertions(+), 10 deletions(-)