Bug 256809 - Add a runtime dependency to www/py-django-reversion-compare
Summary: Add a runtime dependency to www/py-django-reversion-compare
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Dan Langille
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-06-24 14:29 UTC by gettoknowmi
Modified: 2021-07-14 18:45 UTC (History)
1 user (show)

See Also:

Attachments
patch file (1.37 KB, application/x-shellscript)
2021-07-12 16:02 UTC, gettoknowmi 		no flags Details
attaching-patch (692 bytes, patch)
2021-07-12 21:39 UTC, gettoknowmi 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description gettoknowmi 2021-06-24 14:29:17 UTC 
dependency line 
${PYTHON_PKGNAMEPREFIX}>0:textproc/py-diff-match-patch@${PY_FLAVOR}

bump up the portrevision
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2021-06-24 14:29:17 UTC 
Maintainer informed via mail
Comment 2 Dan Langille freebsd_committer freebsd_triage 2021-06-24 14:37:57 UTC 
There is no diff here.
Comment 3 gettoknowmi 2021-07-12 16:02:54 UTC 
Created attachment 226402 [details]
patch file
Comment 4 gettoknowmi 2021-07-12 16:03:08 UTC 
[03:59 PM:] $ pwd
/usr/local/poudriere/ports/head/vrt/py-django-reversion-compare
[03:59 PM:] $ diff Makefile /usr/local/poudriere/ports/head/www/py-django-reversion-compare/Makefile
3d2
< PORTREVISION=	1
13,14d11
<
< RUN_DEPENDS+=	${PYTHON_PKGNAMEPREFIX}diff-match-patch>0:textproc/py-diff-match-patch@${PY_FLAVOR}
Comment 5 Dan Langille freebsd_committer freebsd_triage 2021-07-12 20:24:14 UTC 
(In reply to gettoknowmi from comment #3)

This is .shar file.

That is used when creating a new port, but not for a patch.
Comment 6 Dan Langille freebsd_committer freebsd_triage 2021-07-12 20:25:29 UTC 
(In reply to gettoknowmi from comment #4)
This is what we are looking for.

Instead of that, do:

cd /usr/local/poudriere/ports/head/www/py-django-reversion-compare/

Make your changes here.
Test them.

Then:

git diff > /tmp/patch. 256809.diff

Attach that file here.
Comment 7 Dan Langille freebsd_committer freebsd_triage 2021-07-12 21:18:59 UTC 
sorry, '/tmp/patch. 256809.diff' should be:

/tmp/patch.256809.diff
Comment 8 gettoknowmi 2021-07-12 21:39:19 UTC 
Created attachment 226410 [details]
attaching-patch

attached the new patch
Comment 9 Dan Langille freebsd_committer freebsd_triage 2021-07-13 12:43:38 UTC 
That looks great.

BTW, I will fix this portlint issue with the commit:

$ portlint
FATAL: Makefile: MAINTAINER should be a single address without comment.
FATAL: Makefile: MAINTAINER address, gettoknowmi <gettoknowmi@yahoo.com>, does not appear to be a valid email address.
2 fatal errors and 0 warnings found.
Comment 10 commit-hook freebsd_committer freebsd_triage 2021-07-13 12:53:41 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=cd6c4254801cb5cba1067f1189910c0b4ebfa5fb

commit cd6c4254801cb5cba1067f1189910c0b4ebfa5fb
Author:     Dan Langille <dvl@FreeBSD.org>
AuthorDate: 2021-07-13 12:44:08 +0000
Commit:     Dan Langille <dvl@FreeBSD.org>
CommitDate: 2021-07-13 12:53:03 +0000

    www/py-django-reversion-compare: add missing dep

    * added textproc/py-diff-match-patch as RUN_DEPENDS

    While here, fix MAINTAINER as found by portlint

    PR:             256809
    Reported by:    gettoknowmi <gettoknowmi@yahoo.com> (maintainer)

 www/py-django-reversion-compare/Makefile | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
Comment 11 commit-hook freebsd_committer freebsd_triage 2021-07-14 18:45:03 UTC 
A commit in branch 2021Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c698f1ff69faf1755f4cd1e888a9e9d966459ca4

commit c698f1ff69faf1755f4cd1e888a9e9d966459ca4
Author:     Dan Langille <dvl@FreeBSD.org>
AuthorDate: 2021-07-13 12:44:08 +0000
Commit:     Dan Langille <dvl@FreeBSD.org>
CommitDate: 2021-07-14 18:39:24 +0000

    www/py-django-reversion-compare: add missing dep

    * added textproc/py-diff-match-patch as RUN_DEPENDS

    While here, fix MAINTAINER as found by portlint

    PR:             256809
    Reported by:    gettoknowmi <gettoknowmi@yahoo.com> (maintainer)

    (cherry picked from commit cd6c4254801cb5cba1067f1189910c0b4ebfa5fb)

 www/py-django-reversion-compare/Makefile | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)