Bug 256810 - devel/spdlog: Compatibility fixes withy libfmt 8.0.0
Summary: devel/spdlog: Compatibility fixes withy libfmt 8.0.0
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Vanilla I. Shu
URL:
Keywords:
Depends on: 256808
Blocks:
  Show dependency tree / graph
 
Reported: 2021-06-24 14:33 UTC by Daniel Engberg
Modified: 2021-08-01 15:42 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (vanilla)

Attachments
Patch for spdlog (2.33 KB, patch)
2021-06-24 14:33 UTC, Daniel Engberg 		no flags Details | Diff
patch for spdlog v2 (2.57 KB, patch)
2021-06-24 22:52 UTC, Daniel Engberg 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2021-06-24 14:33:12 UTC 
Created attachment 226035 [details]
Patch for spdlog

Backport following upstream commits to fix compilation with libfmt 8.0.0:
https://github.com/gabime/spdlog/commit/8bf718671a9eac5517c27a5ffe72089b7f426d8c (partially)
https://github.com/gabime/spdlog/commit/8bf718671a9eac5517c27a5ffe72089b7f426d8c
https://github.com/gabime/spdlog/commit/7b14a65b2b8cbdca3c6bd1d36fe5b271389c1d07

The will break compatibility with older versions of libfmt

Compile atested on 13.0-STABLE #0 stable/13-n246086-a20c597c6d7-dirty (amd64) (make, make check-plist)
Poudriere testport OK 12.2-RELEASE (amd64)
Poudriere testport OK 11.4-RELEASE (amd64)
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2021-06-24 22:52:58 UTC 
Created attachment 226045 [details]
patch for spdlog v2

Backport commit https://github.com/gabime/spdlog/commit/68111122086187761cca36c24e6d8c8daa96656d
Comment 2 commit-hook freebsd_committer freebsd_triage 2021-06-27 05:37:37 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=eddbea3915c23a4c27639478022bf73ce4d09a3c

commit eddbea3915c23a4c27639478022bf73ce4d09a3c
Author:     Vanilla I. Shu <vanilla@FreeBSD.org>
AuthorDate: 2021-06-27 05:32:33 +0000
Commit:     Vanilla I. Shu <vanilla@FreeBSD.org>
CommitDate: 2021-06-27 05:36:39 +0000

    devel/spdlog: Compatibility fixes with libfmt 8.0.0.

    PR:             256810
    Reported by:    Daniel Engberg <daniel.engberg.lists at pyret.net>

 devel/spdlog/Makefile                                         |  6 +++++-
 devel/spdlog/distinfo                                         |  6 +++++-
 devel/spdlog/files/patch-include_spdlog_common-inl.h (new)    | 11 +++++++++++
 .../files/patch-include_spdlog_fmt_bin__to__hex.h (new)       | 11 +++++++++++
 4 files changed, 32 insertions(+), 2 deletions(-)