Bug 256982 - graphics/opencv: Add missing dependencies
Summary: graphics/opencv: Add missing dependencies
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Yuri Victorovich
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2021-07-04 16:49 UTC by Philipp Ost
Modified: 2023-12-28 04:29 UTC (History)
1 user (show)

See Also:
tcberner: maintainer-feedback+
koobs: merge-quarterly?


Attachments
graphics/opencv: add missing library dependencies (1.42 KB, patch)
2021-07-04 16:49 UTC, Philipp Ost
no flags Details | Diff
Add missing dependencies (GTK3, gstreamer) (861 bytes, patch)
2022-09-26 21:32 UTC, Philipp Ost
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philipp Ost 2021-07-04 16:49:57 UTC
Created attachment 226223 [details]
graphics/opencv: add missing library dependencies

`make stage-qa` in graphics/opencv complains about several missing library dependencies which are not declared:
1. /usr/local/lib/libopencv_highgui.so.4.5.1 is linked to:
- /usr/local/lib/libgtk-3.so.0
- /usr/local/lib/libgdk-3.so.0
- /usr/local/lib/libcairo.so.2
- /usr/local/lib/libgdk_pixbuf-2.0.so.0
- /usr/local/lib/libgobject-2.0.so.0
- /usr/local/lib/libglib-2.0.so.0
2. /usr/local/lib/libopencv_imgcodecs.so.4.5.1 is linked to:
- /usr/local/lib/libopenjp2.so.7
- /usr/local/lib/libgdal.so.3
3. /usr/local/lib/libopencv_text.so.4.5.1 is linked to /usr/local/lib/libtesseract.so.4
4. /usr/local/lib/libopencv_videoio.so.4.5.1 is linked to:
- /usr/local/lib/libgstbase-1.0.so.0
- /usr/local/lib/libgstreamer-1.0.so.0
- /usr/local/lib/libgstapp-1.0.so.0
- /usr/local/lib/libgstriff-1.0.so.0
- /usr/local/lib/libgstpbutils-1.0.so.0

The patch adds these dependencies and bumps PORTREVISION.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2021-07-04 23:59:41 UTC
^Triage: [tags] in issue Titles are deprecated
Comment 2 Tobias C. Berner freebsd_committer freebsd_triage 2021-07-18 13:56:00 UTC
Moin moin 

Could you please retry against the new version from 
https://cgit.freebsd.org/ports/commit/?id=c582239e8a2b795fc0a7f51a3463cee9998cfab8


mfg Tobias
Comment 3 Philipp Ost 2021-07-19 20:48:06 UTC
(In reply to Tobias C. Berner from comment #2)

Yes. I am working on a new patch.
Comment 4 Yuri Victorovich freebsd_committer freebsd_triage 2022-06-16 03:39:44 UTC
(In reply to Philipp Ost from comment #3)

Any progress?
Comment 5 Philipp Ost 2022-06-16 22:55:06 UTC
(In reply to Yuri Victorovich from comment #4)

Yes, I am actively working on a new patch. The patch is more or less finished, but I still need to do some testing.
Comment 6 Philipp Ost 2022-09-26 21:32:02 UTC
Created attachment 236844 [details]
Add missing dependencies (GTK3, gstreamer)

I'm very sorry this took so long. I got carried away with adding support for QT5 and OpenGL in the same go; there's some nagging problem which I couldn't resolve yet...

Long story short: Here's the updated patch.

It tests fine with poudriere testport using a 13.1-RELEASE amd64 jail. It also builds fine on my 13-STABLE box.
Comment 7 Yuri Victorovich freebsd_committer freebsd_triage 2023-12-28 04:28:51 UTC
Committed, thanks!
Comment 8 commit-hook freebsd_committer freebsd_triage 2023-12-28 04:29:15 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f4670bcfacde62f733b033e30eaa0a16f621cde6

commit f4670bcfacde62f733b033e30eaa0a16f621cde6
Author:     Philipp Ost <bsd@philippost.de>
AuthorDate: 2023-12-28 04:28:06 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2023-12-28 04:28:59 +0000

    graphics/opencv: Add missing dependencies

    PR:             256982

 graphics/opencv/Makefile | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)