Bug 257017 - mail/rainloop: auth plain bug and fix
Summary: mail/rainloop: auth plain bug and fix
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kurt Jaeger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-07-06 12:12 UTC by Kurt Jaeger
Modified: 2021-11-11 02:52 UTC (History)
3 users (show)

See Also:
yasu: maintainer-feedback+
yasu: merge-quarterly+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kurt Jaeger freebsd_committer freebsd_triage 2021-07-06 12:12:42 UTC
rainloop is part of nextcloud. If it tries to speak to some SMTP server, it uses a PHP smtp sub-module, which does AUTH PLAIN with multiline (!), which fails if speaking to exim.

See
https://github.com/RainLoop/rainloop-webmail/issues/1629
and this comment in this very long issue:
https://github.com/RainLoop/rainloop-webmail/issues/1629#issuecomment-540398127

Therefore, rainloop/v/1.16.0/app/libraries/MailSo/Smtp/SmtpClient.php
needs to be changed:

from:
        public $__USE_SINGLE_LINE_AUTH_PLAIN_COMMAND = false;
to:
        public $__USE_SINGLE_LINE_AUTH_PLAIN_COMMAND = true;
Comment 1 Bernard Spil freebsd_committer freebsd_triage 2021-07-15 19:11:35 UTC
Makes sense to chime in on the Rainloop issue, but also with the Nextcloud app on https://github.com/pierre-alain-b/rainloop-nextcloud/issues

Modifying the app will lead to signature errors with the Nextcloud checks.
Comment 2 commit-hook freebsd_committer freebsd_triage 2021-11-11 02:44:31 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=09c2f9d63931380306f66bcbef74667502a0c4e0

commit 09c2f9d63931380306f66bcbef74667502a0c4e0
Author:     Yasuhiro Kimura <yasu@FreeBSD.org>
AuthorDate: 2021-11-11 02:23:43 +0000
Commit:     Yasuhiro Kimura <yasu@FreeBSD.org>
CommitDate: 2021-11-11 02:42:03 +0000

    mail/rainloop: Fix SMTP AUTH PLAIN bug

    While I'm here,

    * Switch to DISTVERSION
    * Pet portclippy
    * Re-format Makefile with portfmt

    Reference:      https://github.com/RainLoop/rainloop-webmail/issues/1629
    PR:             257017
    Reported by:    pi
    Obtained from:  https://github.com/RainLoop/rainloop-webmail/issues/1629#issuecomment-540398127
    MFH:            2021Q4

 mail/rainloop-community/Makefile |  6 +++---
 mail/rainloop/Makefile           | 21 ++++++++++++++++-----
 2 files changed, 19 insertions(+), 8 deletions(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2021-11-11 02:47:32 UTC
A commit in branch 2021Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=676fbc40c6681b804f49eec4e05c0ae9ef655728

commit 676fbc40c6681b804f49eec4e05c0ae9ef655728
Author:     Yasuhiro Kimura <yasu@FreeBSD.org>
AuthorDate: 2021-11-11 02:23:43 +0000
Commit:     Yasuhiro Kimura <yasu@FreeBSD.org>
CommitDate: 2021-11-11 02:46:35 +0000

    mail/rainloop: Fix SMTP AUTH PLAIN bug

    While I'm here,

    * Switch to DISTVERSION
    * Pet portclippy
    * Re-format Makefile with portfmt

    Reference:      https://github.com/RainLoop/rainloop-webmail/issues/1629
    PR:             257017
    Reported by:    pi
    Obtained from:  https://github.com/RainLoop/rainloop-webmail/issues/1629#issuecomment-540398127
    MFH:            2021Q4

    (cherry picked from commit 09c2f9d63931380306f66bcbef74667502a0c4e0)

 mail/rainloop-community/Makefile |  6 +++---
 mail/rainloop/Makefile           | 21 ++++++++++++++++-----
 2 files changed, 19 insertions(+), 8 deletions(-)
Comment 4 Yasuhiro Kimura freebsd_committer freebsd_triage 2021-11-11 02:52:57 UTC
(In reply to Kurt Jaeger from comment #0)

Sorry for having kept you waiting for a long time. Fixed in both main and quarterly branches. Thanks!