Bug 257461 - sysutils/pv: pass LD via MAKE_ENV
Summary: sysutils/pv: pass LD via MAKE_ENV
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Ganael LAPLANCHE
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2021-07-27 20:14 UTC by Ghost
Modified: 2021-07-28 09:24 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (martymac)
2khramtsov: maintainer-feedback?

Attachments
v1 (use "git am" (1006 bytes, patch)
2021-07-27 20:14 UTC, Ghost 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ghost 2021-07-27 20:14:20 UTC 
Created attachment 226745 [details]
v1 (use "git am"

/usr/bin/ld can be absent due to base built WITHOUT_LLD,
external toolchain from ports can be installed instead.

Respect $LD from environment, e.g. when
/usr/local/share/toolchains/*.mk gets included:

ld -r -o src/main.o  src/main/debug.o src/main/help.o src/main/main.o
src/main/options.o src/main/remote.o src/main/version.o
gmake[2]: ld: No such file or directory
gmake[2]: *** [Makefile:352: src/main.o] Error 127

Tier-1 architectures poudriere testport (use "zstdless"):
(ports 84d321345931f4c748d62c104aa536e0fce24295 Tue Jul 27 15:37:24 2021 -0400)

11.4/amd64: OK https://codeberg.org/ei/misc/raw/branch/main/poudriere/pv-1.6.6_114-amd64.log.zst
11.4/i386: OK https://codeberg.org/ei/misc/raw/branch/main/poudriere/pv-1.6.6_114-i386.log.zst
12.2/amd64: OK https://codeberg.org/ei/misc/raw/branch/main/poudriere/pv-1.6.6_122-amd64.log.zst
12.2/i386: OK https://codeberg.org/ei/misc/raw/branch/main/poudriere/pv-1.6.6_122-i386.log.zst
13.0/amd64: OK https://codeberg.org/ei/misc/raw/branch/main/poudriere/pv-1.6.6_130-amd64.log.zst
13.0/aarch64 (qemu-user-static): OK https://codeberg.org/ei/misc/raw/branch/main/poudriere/pv-1.6.6_130-aarch64.log.zst

Runtime on 14-CURRENT base fork + ports fork: OK.

PORTREVISION is not bumped because files of package did not change, only manifest with ports tree hash:

(root of extracted package, git repo initialized before patch) $ git diff

modified:   +COMPACT_MANIFEST
modified:   +MANIFEST
Comment 1 commit-hook freebsd_committer freebsd_triage 2021-07-28 09:23:10 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8a9ab8fccf5d9531fa4b8a52b50cef0b11687072

commit 8a9ab8fccf5d9531fa4b8a52b50cef0b11687072
Author:     Ganael LAPLANCHE <martymac@FreeBSD.org>
AuthorDate: 2021-07-28 09:17:07 +0000
Commit:     Ganael LAPLANCHE <martymac@FreeBSD.org>
CommitDate: 2021-07-28 09:17:07 +0000

    sysutils/pv: pass LD via MAKE_ENV

    /usr/bin/ld can be absent due to base built WITHOUT_LLD, external
    toolchain from ports can be installed instead. Respect $LD from
    environment.

    While here, reorder USES.

    PR:             257461
    Reported by:    Evgeniy Khramtsov <evgeniy AT khramtsov.org>

 sysutils/pv/Makefile | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Comment 2 Ganael LAPLANCHE freebsd_committer freebsd_triage 2021-07-28 09:24:02 UTC 
Committed, thanks a lot!