Bug 257490 - www/firefox doesn't start, complains about epoll_shim
Summary: www/firefox doesn't start, complains about epoll_shim
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Some People
Assignee: Graham Perrin
URL: https://github.com/jiixyj/epoll-shim/...
Keywords:
Depends on:
Blocks:
 
Reported: 2021-07-29 14:41 UTC by Maxim Filimonov
Modified: 2023-04-23 14:17 UTC (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Maxim Filimonov 2021-07-29 14:41:45 UTC 
ld-elf.so.1: /usr/local/lib/firefox/libxul.so: Undefined symbol "epoll_shim_read"

libepoll-shim is installed. 


Looks like libxul.so hasn't been linked with that.
Comment 1 Graham Perrin freebsd_committer freebsd_triage 2021-07-30 07:42:33 UTC 
Please: which version of Firefox, which version of FreeBSD? 

No problem here; 

% pkg info -x firefox
firefox-90.0.2,2
% date ; uname -KrU
Fri 30 Jul 2021 08:41:39 BST
14.0-CURRENT 1400026 1400026
%
Comment 2 Marco Beishuizen 2021-08-12 17:45:47 UTC 
I got this too on 12.2-RELEASE-p6 with latest FF from packages.
Comment 3 commit-hook freebsd_committer freebsd_triage 2021-08-14 21:16:45 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f9af88868ddbbc81bf16226dc529a550a387e589

commit f9af88868ddbbc81bf16226dc529a550a387e589
Author:     Christoph Moench-Tegeder <cmt@FreeBSD.org>
AuthorDate: 2021-08-14 21:13:09 +0000
Commit:     Christoph Moench-Tegeder <cmt@FreeBSD.org>
CommitDate: 2021-08-14 21:13:09 +0000

    www/firefox: depend on libepoll-shim

    libxul.so clearly links against libepoll-shim, and we have reports
    of firefox failing to start without libepoll-shim. this also affects
    mail/thunderbird (once we land it), so fix the problem in bsd.gecko.mk.
    First reports are against firefox 90, set the version cutoff
    accordingly.

    PR:             257490
    Reported by:    Maxim Filimonov

 Mk/bsd.gecko.mk      | 3 +++
 www/firefox/Makefile | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)
Comment 4 commit-hook freebsd_committer freebsd_triage 2021-08-14 21:17:46 UTC 
A commit in branch 2021Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ddd062a23ce3d4bd78b98d6ecfae2afa4725753b

commit ddd062a23ce3d4bd78b98d6ecfae2afa4725753b
Author:     Christoph Moench-Tegeder <cmt@FreeBSD.org>
AuthorDate: 2021-08-14 21:13:09 +0000
Commit:     Christoph Moench-Tegeder <cmt@FreeBSD.org>
CommitDate: 2021-08-14 21:17:13 +0000

    www/firefox: depend on libepoll-shim

    libxul.so clearly links against libepoll-shim, and we have reports
    of firefox failing to start without libepoll-shim. this also affects
    mail/thunderbird (once we land it), so fix the problem in bsd.gecko.mk.
    First reports are against firefox 90, set the version cutoff
    accordingly.

    PR:             257490
    Reported by:    Maxim Filimonov

    (cherry picked from commit f9af88868ddbbc81bf16226dc529a550a387e589)

 Mk/bsd.gecko.mk      | 3 +++
 www/firefox/Makefile | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)
Comment 5 Christoph Moench-Tegeder freebsd_committer freebsd_triage 2021-08-14 21:22:37 UTC 
So, first register the dependency..

Then:
Whad does "ldd /usr/local/lib/firefox/libxul.so" and "/usr/bin/objdump -T /usr/local/lib/libepoll-shim.so" show?
Comment 6 Jan Beich freebsd_committer freebsd_triage 2021-08-14 22:07:58 UTC 
Likely a duplicate of bug 248232. FreeBSD >= 13.0 has eventfd, so libepoll-shim isn't used.
Comment 7 Jan Beich freebsd_committer freebsd_triage 2021-08-14 22:15:01 UTC 
eventfd from libepoll-shim is unusable by Firefox, see https://github.com/jiixyj/epoll-shim/issues/23.