Created attachment 227015 [details] games/brogue: Update to 1.10.1 A patch release. Changes: * Fixed an out-of-sync error when loading a game with a 64-bit seed. * (For distributors) Added an experimental --data-dir option for specifying the location of game resources. https://github.com/tmewett/BrogueCE/releases/tag/v1.10.1 Tested with Poudriere on armv7 arm64 amd64 i386 FreeBSD 13.0-RELEASE.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=c4fcb1ebebc1c6e7728ec3482f1a93a0cb572829 commit c4fcb1ebebc1c6e7728ec3482f1a93a0cb572829 Author: Robert Clausecker <fuz@fuz.su> AuthorDate: 2021-08-11 16:35:55 +0000 Commit: Nuno Teixeira <eduardo@FreeBSD.org> CommitDate: 2021-08-11 16:38:46 +0000 games/brogue: Update to 1.10.1 * reformat Makefile with portfmt ChangeLog: https://github.com/tmewett/BrogueCE/releases/tag/v1.10.1 PR: 257681 games/brogue/Makefile | 29 +++++++++++++---------------- games/brogue/distinfo | 6 +++--- 2 files changed, 16 insertions(+), 19 deletions(-)
Committed thanks!
Come on, that reformat was totally pointless. The order of variables was intentional the way it was. Please don't just randomly change meaningless things.
(In reply to Robert Clausecker from comment #3) Hello, I use portlint, portclippy and portfmt tools not in a blindly way but sometimes I make mistakes. Could you please reformat it again so I can correct what I did wrong? Please send a diff. Thanks
(In reply to Nuno Teixeira from comment #4) Just undo all the reformatting you did. But really, there's no need to make an extra commit for that. I'll just restore the formatting next time there's an update. I had previously formatted the port in a way that makes sense. Especially the different variable ordering (PLIST_SUB went into a different place because it only applies to SUB_FILES, so it should be right next to that variable). Also, PORTDATA should have one file per line (like PLIST_FILES) so it is clear what files were added and removed in a diff. Likewise, the USE_SDL rule had sdl2 in the front because that's the base component and image2 is a sub component. Portfmt doesn't know about these things. It's a dumb tool with very primitive formatting rules and I usually avoid it because it often yields less than useful results. Just blindly applying PORTFMT to random people's ports is not really a good idea, especially not without asking for confirmation.