Created attachment 227252 [details] math/linbox: add ocl dependency math/linbox currently picks up libOpenCL.so if it is present on the system, but does not declare it as a dependency. The attached patch adds it as a library dependency to the complete package and disables it for the minimal package. This came up in testing my changes: iff MIN=on, then LinBox unconditionally picks up libflint.so and libtinyxml2.so if they are present on the system. Adding --without-flint to the configure arguments does not have an effect. There seems to be no option to disable tinyxml2 (the doxygen option is off).
You are right, it depends on libOpenCL.so when devel/ocl-icd is installed! But have'nt you noticed anything about pkg-plist? On my workstation (13-STABLE), installed from the ports, I must insert the following line: %%FULL%%include/linbox/algorithms/opencl-kernels/opencl-domain-kernels.inl but in poudriere, this file is not installed, and I have not yet found the reason.
Created attachment 227404 [details] math/linbox: add ocl dependency I missed checking for changes to pkg-plist. Sorry about that. I revised my patch to include the missing file. opencl-domain-kernels.inl is generated by ${WRKSRC}/linbox/algorithms/opencl-kernels/kernel-parser.py and referenced in the Makefile in same directory. Skimming through that Makefile, I see no reason for that include file to not be installed. poudriere testport is currently running, I'll report back if I find something.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=d2bb2bbfa994359bd8352b8d83101531611583ff commit d2bb2bbfa994359bd8352b8d83101531611583ff Author: Philipp Ost <bsd@philippost.de> AuthorDate: 2023-08-04 15:29:16 +0000 Commit: Thierry Thomas <thierry@FreeBSD.org> CommitDate: 2023-08-04 15:37:57 +0000 math/linbox: add OpenCL dependency math/linbox currently picks up libOpenCL.so if it is present on the system, but does not declare it as a dependency. The attached patch adds it as a library dependency to the complete package and disables it for the minimal package. PR: 257891 Reported by: bsd (at) philippost.de math/linbox/Makefile | 9 ++++++--- math/linbox/pkg-plist | 1 + 2 files changed, 7 insertions(+), 3 deletions(-)
Committed, thanks! (Sorry for the delay, I didn't see your updated patch!)