Bug 257921 - emulators/virtualbox-ose: don't hardcode compiler version
Summary: emulators/virtualbox-ose: don't hardcode compiler version
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Virtualbox Team (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-08-18 03:29 UTC by Maxim Sobolev
Modified: 2021-09-04 16:26 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (vbox)

Attachments
Patch to fix the issue. (645 bytes, patch)
2021-08-18 03:29 UTC, Maxim Sobolev 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Maxim Sobolev freebsd_committer freebsd_triage 2021-08-18 03:29:40 UTC 
Created attachment 227298 [details]
Patch to fix the issue.

emulators/virtualbox-ose allows compiler version to be defined via VBOX_LLVM_VER, however BUILD_DEPENDS contains hardcoded "clang11" as binary name.
Comment 1 Guido Falsi freebsd_committer freebsd_triage 2021-08-19 09:01:04 UTC 
(In reply to Maxim Sobolev from comment #0)

Hi,

good catch.

I have no objection to the patch per se, since it is technically correct.

At the same time I think it is highly improbable that virtualbox really compiles or works if VBOX_LLVM_VER is set to anything except "11"
Comment 2 commit-hook freebsd_committer freebsd_triage 2021-09-04 16:22:50 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=384ca6fe490afc8e19c843ffe273081a16df036b

commit 384ca6fe490afc8e19c843ffe273081a16df036b
Author:     Maxim Sobolev <sobomax@FreeBSD.org>
AuthorDate: 2021-09-04 16:16:59 +0000
Commit:     Guido Falsi <madpilot@FreeBSD.org>
CommitDate: 2021-09-04 16:18:29 +0000

    emulators/virtualbox-ose: don't hardcode compiler version

    PR:             257921

 emulators/virtualbox-ose/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 3 Guido Falsi freebsd_committer freebsd_triage 2021-09-04 16:26:18 UTC 
I committed your patch. Thanks!