Created attachment 227561 [details]
poudriere log

Comment 2 Fernando Apesteguía 2021-08-31 07:58:57 UTC

^Triage: If there is a changelog or release notes URL available for this version, please add it to the URL field.

^Triage: Maintainer-feedback flag (+) not required unless requested (?) first.


Thanks!

Comment 3 Fernando Apesteguía 2021-08-31 07:59:47 UTC

Mid-air collision with Rainer :-)

Comment 4 Rainer Hurling 2021-08-31 10:15:06 UTC

Created attachment 227568 [details]
pet portclippy with sorted Makefile

Thanks for the patch!

I tested on Poudriere and a real life box and it seems fine so far :D

portclippy complains about the sorting of some Makefile vars. If it would be ok for you, I would commit the Makefile as sorted in the new patch. 

Please have a look and give a short feedback, many thanks ;)

Created attachment 227580 [details]
patch for astro/geographiclib

Removed line breaks in block splitting so that it is similar to the many ports that have not follow portclippy yet. portlint says looks fine.
The \ escapes for line break have been reverted to some extent because of the following semantic changes.

EX_A=   ---> \
        <--- The spaces between here are replaced by 2 space characters.
EX_B=   --->\
        <--- The spaces between here are replaced by 1 space character.

Comment on attachment 227568 [details]
pet portclippy with sorted Makefile

attachment 227580 [details] is recommended.

Comment 7 Rainer Hurling 2021-09-01 04:32:15 UTC

(In reply to Tatsuki Makino from comment #6)
I agree with the retraction of these backslashes of course ;)

However, the backslashes were only changed between different "-e ' " blocks of the sed command, so this should have no effect on the replacements. Or is it different in the x-tool-plist target?

(In reply to Rainer Hurling from comment #7)

There will be one more space character in the command echoed by make :)
it is because newlines are converted to a single space character and echoed.
All space and tab characters from the beginning of the line will be deleted.
And, not that it matters, but the line following the escaped newline (which indented lines with 2 levels of tabs) doesn't actually need to be indented :)

This is simply a matter of visual appearance :)
However, I thought that if the official automatic formatter does not ask for a correction, then why bother changing it this time? portlint also says looks fine.

Comment 9 Rainer Hurling 2021-09-01 06:24:16 UTC

(In reply to Tatsuki Makino from comment #8)

As said before, your reasoning is perfectly fine with me ;)

Ok, so I think we are ready now to commit your latest patch, aren't we?

(In reply to Rainer Hurling from comment #9)

Yes. There is no problem on my end.
poudriere output exactly the same log as the attachment 227561 [details] except for the time and the version of poudriere.

Comment 11 commit-hook 2021-09-01 08:02:24 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=24157ac4123f41a696c5f4511709e932f3afe06d

commit 24157ac4123f41a696c5f4511709e932f3afe06d
Author:     Tatsuki Makino <tatsuki_makino@hotmail.com>
AuthorDate: 2021-09-01 06:44:32 +0000
Commit:     Rainer Hurling <rhurlin@FreeBSD.org>
CommitDate: 2021-09-01 08:00:30 +0000

    astro/geographiclib: Update to 1.52

    Changelog: https://sourceforge.net/p/geographiclib/news/2021/06/geographiclib-152-released-2021-06-22/

    PR:             258175

 astro/geographiclib/Makefile                       | 50 +++++++++++-----------
 astro/geographiclib/distinfo                       |  6 +--
 astro/geographiclib/files/patch-CMakeLists.txt     |  2 +-
 .../geographiclib/files/patch-cmake_CMakeLists.txt |  4 +-
 astro/geographiclib/pkg-plist                      |  7 +--
 5 files changed, 36 insertions(+), 33 deletions(-)

Comment 12 Rainer Hurling 2021-09-01 08:06:44 UTC

Committed :)

Thanks for your fast responses.

(In reply to Rainer Hurling from comment #12)

Thank you very much.