Bug 258333 - devel/msitools: Fix build and minor tweaks
Summary: devel/msitools: Fix build and minor tweaks
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Romain Tartière
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-09-07 08:05 UTC by Daniel Engberg
Modified: 2021-09-07 23:02 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (romain)

Attachments
Patch for msitools (9.22 KB, patch)
2021-09-07 08:05 UTC, Daniel Engberg 		romain: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2021-09-07 08:05:57 UTC 
Created attachment 227731 [details]
Patch for msitools

Backport upstream commits b08275d549bb12a09a420ef9ccaeb0974e00008a (fixes build), 25c4353cf173cddeb76c0a2dd6621bcb753cabf8 (sets msidiff and msidump as executable)
Convert to DISTVERSION and remove INSTALL_TARGET (not needed)

Compile tested on FreeBSD 13.0-STABLE #0 stable/13-n246086-a20c597c6d7 (amd64) (make, make check-plist)
Poudriere testport OK 12.2-RELEASE (amd64)
Poudriere testport OK 11.4-RELEASE (amd64)

Reported here: https://portsfallout.com/port/4986/
Comment 1 Romain Tartière freebsd_committer freebsd_triage 2021-09-07 22:56:36 UTC 
Comment on attachment 227731 [details]
Patch for msitools

Ah cool!  I was unable to reproduce these failures
Comment 2 commit-hook freebsd_committer freebsd_triage 2021-09-07 23:02:28 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2fbc04974c3619da735cc4c19e4b37688869f356

commit 2fbc04974c3619da735cc4c19e4b37688869f356
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2021-09-07 23:00:31 +0000
Commit:     Romain Tartière <romain@FreeBSD.org>
CommitDate: 2021-09-07 23:00:31 +0000

    devel/msitools: Fix build and minor tweaks

    PR:             258333

 devel/msitools/Makefile  |   9 ++-
 devel/msitools/distinfo  |   6 +-
 devel/msitools/pkg-plist | 154 +++++++++++++++++++++++------------------------
 3 files changed, 88 insertions(+), 81 deletions(-)
Comment 3 Romain Tartière freebsd_committer freebsd_triage 2021-09-07 23:02:53 UTC 
Committed, thanks!