Bug 258373 - devel/simdjson: update to 1.0.0
Summary: devel/simdjson: update to 1.0.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Yuri Victorovich
URL: https://github.com/simdjson/simdjson/...
Keywords:
Depends on:
Blocks:
 
Reported: 2021-09-08 19:16 UTC by Oleg Ginzburg
Modified: 2022-07-13 05:01 UTC (History)
4 users (show)

See Also:


Attachments
devel/simdjson: update to 1.0.0 (1.62 KB, patch)
2021-09-08 19:16 UTC, Oleg Ginzburg
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oleg Ginzburg 2021-09-08 19:16:18 UTC
Created attachment 227769 [details]
devel/simdjson: update to 1.0.0

changes: https://github.com/simdjson/simdjson/releases/tag/v1.0.0
Comment 1 Nuno Teixeira freebsd_committer freebsd_triage 2021-09-09 13:34:52 UTC
Hello,

1. Makefile says:
---
BROKEN_i386=    does not build (error: unknown type name '__uint128_t')
---

Poudriere tests at https://people.freebsd.org/~eduardo/logs/simdjson-1.0.0/ compiles ok on i386 with a warning:
---
warning: The simdjson library is designed for 64-bit processors and it seems that you are not compiling for a known 64-bit platform. All fast kernels will be disabled and performance may be poor. Please use a 64-bit target such as x64, 64-bit ARM or 64-bit PPC. [-W#pragma-messages]
---

Maybe upstream have done some compatibily with i386?

2. Small order fix (from portclippy):

Move "CXXFLAGS_powerpc64" to CFLAGS/CXXFLAGS/LDFLAGS block:

---
# PORTNAME block
PORTNAME
DISTVERSIONPREFIX
DISTVERSION
CATEGORIES

# Maintainer block
MAINTAINER
COMMENT

# License block
LICENSE
LICENSE_FILE

# BROKEN/IGNORE/DEPRECATED messages
BROKEN_i386

-CXXFLAGS_powerpc64 <==

# USES block
USES
USE_GITHUB
USE_LDCONFIG

# USES=cmake related variables
CMAKE_ON

# CFLAGS/CXXFLAGS/LDFLAGS block
+CXXFLAGS_powerpc64 <==
---

Could you test this on i386?
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2021-10-05 00:47:41 UTC
Hi Oleg,

Are there any noticable improvements building this port with -O3?
https://github.com/simdjson/simdjson#performance-results

Is it possible to enable unit tests?

Best regards,
Daniel
Comment 3 Daniel Engberg freebsd_committer freebsd_triage 2021-11-02 20:59:44 UTC
Friendly ping
Comment 4 Thierry Thomas freebsd_committer freebsd_triage 2022-06-01 16:49:08 UTC
Note that version 2.0.1 was released on May 26th:
https://github.com/simdjson/simdjson/releases/tag/v2.0.1
Comment 5 Yuri Victorovich freebsd_committer freebsd_triage 2022-07-13 05:01:03 UTC
Updated to 2.2.0
Comment 6 commit-hook freebsd_committer freebsd_triage 2022-07-13 05:01:35 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=427feae70d7065b9083c73a3fb139bc11efb7a3a

commit 427feae70d7065b9083c73a3fb139bc11efb7a3a
Author:     Yuri Victorovich <yuri@FreeBSD.org>
AuthorDate: 2022-07-13 04:59:34 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2022-07-13 05:01:04 +0000

    devel/simdjson: Update 0.9.6 -> 2.2.0

    PR:             258373
    Approved by:    olevole@olevole.ru (maintainer's timeout; 10 months)

 devel/simdjson/Makefile                              |  7 +++++--
 devel/simdjson/distinfo                              |  6 +++---
 ...tch-include_simdjson_ppc64_numberparsing.h (gone) | 20 --------------------
 devel/simdjson/pkg-plist                             |  8 ++++----
 4 files changed, 12 insertions(+), 29 deletions(-)