Created attachment 227796 [details] Remove unnecessary patch file The attached patch removes the file "files/patch-commands.c" from the FreeBSD port of ftp/bftpd. The patch-commands.c file adjusts included headers for Bftpd which should no longer be needed. I've tested this on FreeBSD 12.x and the port still builds and runs the same with or without the patch-commands.c file in the port.
Created attachment 227799 [details] patch to remove patchfile and pet portlint Hi Jesse, Thanks for the patch. While testing it on Poudriere, 'portlint -AC' gives the following warnings: WARN: Makefile: [32]: possible use of "${FIND} ... ${XARGS} ${RM}" when "${FIND} ... -delete" will work. WARN: Makefile: "USES" has to appear earlier. To turn off the first warning, only USES= had to be moved in the Makefile. When testing '@${FIND} ${WRKSRC} -name CVS -delete' it turned out that the sources no longer contain a file named CVS. Therefore the whole line can be omitted. I have therefore attached a patch that not only deletes the files directory, but also takes into account the two changes in the Makefile. Please check if I understood everything correctly and if the patch works as expected.
This change looks good to me. Please go ahead with applying the new patch which also fixes the Makefile.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=c3c3d04764ff6d1999b34cb807383999babf7bda commit c3c3d04764ff6d1999b34cb807383999babf7bda Author: Jesse Smith <jsmith@resonatingmedia.com> AuthorDate: 2021-09-10 05:39:54 +0000 Commit: Rainer Hurling <rhurlin@FreeBSD.org> CommitDate: 2021-09-10 13:21:52 +0000 ftp/bftpd: Remove unnecessary patchfile While here, pet portlint and remove unneeded post-patch. PR: 258395 ftp/bftpd/Makefile | 5 ++--- ftp/bftpd/files/patch-commands.c (gone) | 27 --------------------------- 2 files changed, 2 insertions(+), 30 deletions(-)
Committed. Thanks for the fast reponse :)