Bug 258893 - graphics/xaos: does not compile on current/14
Summary: graphics/xaos: does not compile on current/14
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Rainer Hurling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-10-03 16:12 UTC by Jörg Preiß
Modified: 2021-10-04 11:24 UTC (History)
2 users (show)

See Also:

Attachments
Add clocale include file in main.cpp where LC_NUMERIC was missing (213 bytes, text/plain)
2021-10-03 16:12 UTC, Jörg Preiß 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jörg Preiß 2021-10-03 16:12:09 UTC 
Created attachment 228403 [details]
Add clocale include file in main.cpp where LC_NUMERIC was missing

I tried to compile the latest port in xaos, but it fails with LC_NUMERIC in src/ui/main.cpp undefined. 
It seems that some header files changed from stable/13 to current/14.
Comment 1 Rainer Hurling freebsd_committer freebsd_triage 2021-10-04 06:24:37 UTC 
Hi Jörg,

Thanks for the patch. Seems to build fine on Poudriere :)

Can you imagine taking over the port as maintainer?
Comment 2 Jörg Preiß 2021-10-04 08:59:37 UTC 
I am still wondering what happens or should happen when there is a new version of xaos, but yes - I can imagine.
Comment 3 commit-hook freebsd_committer freebsd_triage 2021-10-04 11:16:39 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=fa9a7b9c50badbb469594f77af4f31435df3a767

commit fa9a7b9c50badbb469594f77af4f31435df3a767
Author:     Joerg Preiss <joerg.preiss@slesa.de>
AuthorDate: 2021-10-04 11:05:50 +0000
Commit:     Rainer Hurling <rhurlin@FreeBSD.org>
CommitDate: 2021-10-04 11:05:50 +0000

    graphics/xaos: Fix build on HEAD

    Add clocale include in src/ui/main.cpp where LC_NUMERIC was missing.

    Pass maintainership to submitter.

    PR:             258893

 graphics/xaos/Makefile                          |  2 +-
 graphics/xaos/files/patch-src_ui_main.cpp (new) | 10 ++++++++++
 2 files changed, 11 insertions(+), 1 deletion(-)
Comment 4 Rainer Hurling freebsd_committer freebsd_triage 2021-10-04 11:24:53 UTC 
Thanks for taking the port and have fun ;)
If you have questions, do not hesitate to ask.

Committed, thanks!