Bug 258896 - net/haproxy: patch to fix possible stalling connection
Summary: net/haproxy: patch to fix possible stalling connection
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dmitry Sivachenko
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-10-03 17:52 UTC by Matthias Fechner
Modified: 2021-10-03 18:35 UTC (History)
1 user (show)

See Also:
demon: maintainer-feedback+

Attachments
Patch provied on mailinglist, maybe you want to include it till a new version is released. (1.15 KB, application/mbox)
2021-10-03 17:52 UTC, Matthias Fechner 		no flags Details
Patch provied on mailinglist, maybe you want to include it till a new version is released. (1.15 KB, patch)
2021-10-03 17:55 UTC, Matthias Fechner 		no flags Details | Diff
Sry, just saw that the PR was missing in the commit message (1.51 KB, patch)
2021-10-03 18:01 UTC, Matthias Fechner 		mfechner: maintainer-approval?
Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias Fechner freebsd_committer freebsd_triage 2021-10-03 17:52:25 UTC 
Created attachment 228409 [details]
Patch provied on mailinglist, maybe you want to include it till a new version is released.
Comment 1 Matthias Fechner freebsd_committer freebsd_triage 2021-10-03 17:52:54 UTC 
Let me know, if you want to commit it by yourself or if I should commit it.
Comment 2 Matthias Fechner freebsd_committer freebsd_triage 2021-10-03 17:55:30 UTC 
Created attachment 228410 [details]
Patch provied on mailinglist, maybe you want to include it till a new version is released.
Comment 3 Matthias Fechner freebsd_committer freebsd_triage 2021-10-03 17:56:48 UTC 
For convinience also here:
https://gitlab.fechner.net/mfechner/Gitlab/-/commit/3f677e492f9376b88d2e8c83f47acadba4634cb3
Comment 4 Matthias Fechner freebsd_committer freebsd_triage 2021-10-03 17:57:37 UTC 
And to make it clear, I deployed the new version already as haproxy was not working, so it is fully tested ;)
Comment 5 Matthias Fechner freebsd_committer freebsd_triage 2021-10-03 18:01:45 UTC 
Created attachment 228411 [details]
Sry,  just saw that the PR was missing in the commit message

https://gitlab.fechner.net/mfechner/Gitlab/-/commit/495fc4b01da5791c4fafd6d0bd42d0545858c8b4
Comment 6 Dmitry Sivachenko freebsd_committer freebsd_triage 2021-10-03 18:28:41 UTC 
I saw this patch on ML, was planning to merge it later today.
Please go ahead and commit it since you did it faster :)

Thanks!
Comment 7 commit-hook freebsd_committer freebsd_triage 2021-10-03 18:34:49 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5e04d591a2c56b667d0b35286366970568c1cc9c

commit 5e04d591a2c56b667d0b35286366970568c1cc9c
Author:     Matthias Fechner <mfechner@FreeBSD.org>
AuthorDate: 2021-10-03 17:48:18 +0000
Commit:     Matthias Fechner <mfechner@FreeBSD.org>
CommitDate: 2021-10-03 18:34:04 +0000

    net/haproxy: Fix a stalled connection

    This fix fixes a typo in It is a typo in the commit feca2a453
    ("BUG/MINOR: filters: Always set FLT_END analyzer when CF_FLT_ANALYZE flag is set").

    Patch was provided on haproxy mailinglist from Christopher Faulet.

    PR:             258896
    Approved by:    demon (maintainer)

 net/haproxy/Makefile                        |  1 +
 net/haproxy/files/patch-src_filters.c (new) | 11 +++++++++++
 2 files changed, 12 insertions(+)
Comment 8 Matthias Fechner freebsd_committer freebsd_triage 2021-10-03 18:35:13 UTC 
Thanks a lot, is committed.