Bug 259000 - security/p5-openxpki: Fix shebang related bugs
Summary: security/p5-openxpki: Fix shebang related bugs
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Yasuhiro Kimura
URL: https://github.com/openxpki/openxpki
Keywords: easy
Depends on:
Blocks:
 
Reported: 2021-10-08 07:35 UTC by Sergei Vyshenski
Modified: 2021-11-01 08:57 UTC (History)
3 users (show)

See Also:
svysh.fbsd: maintainer-feedback+
koobs: merge-quarterly?


Attachments
patch to update the port (1.68 KB, patch)
2021-10-08 07:35 UTC, Sergei Vyshenski
svysh.fbsd: maintainer-approval+
Details | Diff
"git diff" to update the port (1.79 KB, patch)
2021-10-30 14:57 UTC, Sergei Vyshenski
svysh.fbsd: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sergei Vyshenski 2021-10-08 07:35:35 UTC
Created attachment 228512 [details]
patch to update the port

- Fix shebang related bugs in port
	3.14.4 -> 3.14.4_1

- "portlint -AC" says: Looks fine.
- "portclippy Makefile" is happy.
- "portfmt -D Makefile" is happy.
- "rclint -v files/openxpki.in" gives non-relevant warnings.
- Tested with:
13.0-RELEASE-p4
pkg 1.17.2
poudriere 3.3.7_1
perl 5.32.1_1
openssl 1.1.1k
ssl=base
- During build, non-relevannt warns are issued about possible redundant use of 
modules from perl core.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2021-10-08 07:40:59 UTC
Thank you Sergei.

Has this been tested with other values USES=ssl? Do any values need to be IGNORE'd (due non explicit non support), or BROKEN?

^Triage: Bugfix release: MFH
Comment 2 Sergei Vyshenski 2021-10-08 10:33:59 UTC
(In reply to Kubilay Kocak from comment #1)

openssl-3+ is _not_ supported by the upstream.
Other versions of openssl (available to FreeBSD) _are_ supported and have been tested.
With libressl and libressl-devel you can build fine, but actual operations are not fully tested. files/pkg-message.in has a special note about libressl case.
Case "ssl=base" is emphasized here because it is default and in use of package build machinery.
As I can see, openssl-3.0.0 is with openssl-devel, which is not an option for DEFAULT_VERSIONS (see Mk/Uses/ssl.mk). So, maybe nothing to IGNORE?
Comment 3 Sergei Vyshenski 2021-10-30 14:57:20 UTC
Created attachment 229146 [details]
"git diff" to update the port

Respect changes to the port made during waiting of this PR to be considered:

https://cgit.freebsd.org/ports/diff/security/p5-openxpki/Makefile?id=819f25b36d45b8ac5593ec8e6f470d9ad454b08a
Comment 4 Yasuhiro Kimura freebsd_committer freebsd_triage 2021-11-01 08:16:56 UTC
Take.
Comment 5 commit-hook freebsd_committer freebsd_triage 2021-11-01 08:21:54 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=7e96b5f51e6be90611ac7828980e61f31998e07b

commit 7e96b5f51e6be90611ac7828980e61f31998e07b
Author:     Sergei Vyshenski <svysh.fbsd@gmail.com>
AuthorDate: 2021-11-01 08:13:17 +0000
Commit:     Yasuhiro Kimura <yasu@FreeBSD.org>
CommitDate: 2021-11-01 08:20:30 +0000

    security/p5-openxpki: Fix shebang related bugs

    * Update CONFLICTS
    * Update pkg-message

    PR:             259000
    MFH:            2021Q4

 security/p5-openxpki/Makefile             | 8 +++++---
 security/p5-openxpki/files/pkg-message.in | 4 +---
 2 files changed, 6 insertions(+), 6 deletions(-)
Comment 6 commit-hook freebsd_committer freebsd_triage 2021-11-01 08:52:00 UTC
A commit in branch 2021Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5c86b88038aac08d8337e01247b867dece1e2268

commit 5c86b88038aac08d8337e01247b867dece1e2268
Author:     Sergei Vyshenski <svysh.fbsd@gmail.com>
AuthorDate: 2021-11-01 08:13:17 +0000
Commit:     Yasuhiro Kimura <yasu@FreeBSD.org>
CommitDate: 2021-11-01 08:50:44 +0000

    security/p5-openxpki: Fix shebang related bugs

    * Update CONFLICTS
    * Update pkg-message

    PR:             259000
    MFH:            2021Q4
    (cherry picked from commit 7e96b5f51e6be90611ac7828980e61f31998e07b)

 security/p5-openxpki/Makefile             | 10 ++++++----
 security/p5-openxpki/files/pkg-message.in |  4 +---
 2 files changed, 7 insertions(+), 7 deletions(-)
Comment 7 Yasuhiro Kimura freebsd_committer freebsd_triage 2021-11-01 08:57:21 UTC
Committed and merged to quarterly branch. Thanks!