Bug 259022 - sysutils/py-diffoscope: Update to 187
Summary: sysutils/py-diffoscope: Update to 187
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Guangyuan Yang
URL: https://diffoscope.org/news/diffoscop...
Keywords:
Depends on:
Blocks:
 
Reported: 2021-10-09 08:28 UTC by Guangyuan Yang
Modified: 2021-10-13 01:22 UTC (History)
1 user (show)

See Also:
koobs: maintainer-feedback+

Attachments
Proposed patch (986 bytes, text/plain)
2021-10-09 08:28 UTC, Guangyuan Yang 		koobs: maintainer-approval+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Guangyuan Yang freebsd_committer freebsd_triage 2021-10-09 08:28:53 UTC 
Created attachment 228537 [details]
Proposed patch

It passes QA and some quick manual testing. The test suite reports some failures which are the same as the current version (no regressions). Feature release, not recommending to MFH this.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2021-10-10 23:00:27 UTC 
(In reply to Guangyuan Yang from comment #0)

Approved if it satisfies MAINTAINER_POLICY. For any future change proposals, please include a proposed commit log message, so that it and any upstream changes can be understood with full context for the review

Thanks! :)
Comment 2 Guangyuan Yang freebsd_committer freebsd_triage 2021-10-11 08:20:54 UTC 
(In reply to Kubilay Kocak from comment #1)

Proposed commit msg:

sysutils/py-diffoscope: Update to 187

Changes: https://diffoscope.org/news/diffoscope-187-released/

PR: XXXXXX
Approved by: koobs (maintainer)
(MFH: 2021Q4 (reason) if needed)

Further commit messages will be very similar, so I will skip that, but will keep the URL field of the PR updated.

I would still appreciate explicit approvals (maintainer-feedback (+)) from the maintainer as it is the standard policy. Thank you!
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2021-10-12 00:18:12 UTC 
(In reply to Guangyuan Yang from comment #2)

Feel free to create reviews instead of bugs, with the SUMMARY being the commit log message. Other than that, if MAINTAINER_POLICY is otherwise satisfied, you may and are always free to:

Approved by: koobs (maintainer, MAINTAINER_POLICY, implicit)

Thanks you again! :)
Comment 4 Guangyuan Yang freebsd_committer freebsd_triage 2021-10-12 05:50:47 UTC 
(In reply to Kubilay Kocak from comment #3)

I would still like to follow the standard policy and request explicit feedback (maintainer-feedback (+)) from you if that is okay with you. Thanks!
Comment 5 Kubilay Kocak freebsd_committer freebsd_triage 2021-10-12 05:53:35 UTC 
LGMT :)
Comment 6 commit-hook freebsd_committer freebsd_triage 2021-10-12 20:13:10 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=4794560cf87717184c7b0658388edfdbb26e00e4

commit 4794560cf87717184c7b0658388edfdbb26e00e4
Author:     Guangyuan Yang <ygy@FreeBSD.org>
AuthorDate: 2021-10-12 20:12:01 +0000
Commit:     Guangyuan Yang <ygy@FreeBSD.org>
CommitDate: 2021-10-12 20:12:01 +0000

    sysutils/py-diffoscope: Update to 187

    Changelog:      https://diffoscope.org/news/diffoscope-187-released/

    PR:             259022
    Approved by:    koobs (maintainer)

 sysutils/py-diffoscope/Makefile | 2 +-
 sysutils/py-diffoscope/distinfo | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)
Comment 7 Kubilay Kocak freebsd_committer freebsd_triage 2021-10-13 01:22:18 UTC 
^Triage: Assign to committer that resolves. 

When resolving issues (any issues), please self-assign prior to resolving, keeping maintainer or assignee CC'd where necessary :)