Bug 259061 - devel/py-apispec: Update to 5.1.1
Summary: devel/py-apispec: Update to 5.1.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Nuno Teixeira
URL: https://github.com/marshmallow-code/a...
Keywords:
Depends on:
Blocks:
 
Reported: 2021-10-11 06:45 UTC by Goran Mekić
Modified: 2021-10-12 08:36 UTC (History)
1 user (show)

See Also:

Attachments
apispec.diff (843 bytes, patch)
2021-10-11 06:45 UTC, Goran Mekić 		meka: maintainer-approval+
Details | Diff
apispec.diff (843 bytes, patch)
2021-10-11 07:05 UTC, Goran Mekić 		meka: maintainer-approval+
Details | Diff
apispec.diff (1.87 KB, patch)
2021-10-12 08:00 UTC, Goran Mekić 		meka: maintainer-approval+
Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Goran Mekić 2021-10-11 06:45:06 UTC 
Created attachment 228578 [details]
apispec.diff

QA:

  * portlint: OK (looks fine.)
  * testport: OK (poudriere: 13.0, amd64 tested)
  * maketest: OK (518 passed)
Comment 1 Nuno Teixeira freebsd_committer freebsd_triage 2021-10-11 06:55:56 UTC 
Hello,

diff shows that you are downgrading from 5.1.1 -> 5.1.0

Please correct diff
Comment 2 Goran Mekić 2021-10-11 07:05:43 UTC 
Created attachment 228579 [details]
apispec.diff

I'm sorry, I switched argument places when generating git diff. Thank you!
Comment 3 Nuno Teixeira freebsd_committer freebsd_triage 2021-10-11 07:46:43 UTC 
Hello,

just a minor fix in TEST_DEPENDS lists, alphabetical order (portfmt -D Makefile):
---
--- Makefile
+++ Makefile
@@ -10,14 +10,14 @@
 LICENSE=       MIT
 LICENSE_FILE=  ${WRKSRC}/LICENSE

+TEST_DEPENDS=  ${PYTHON_PKGNAMEPREFIX}marshmallow>0:devel/py-marshmallow@${PY_FLAVOR} \
+               ${PYTHON_PKGNAMEPREFIX}mock>0:devel/py-mock@${PY_FLAVOR} \
-TEST_DEPENDS=  ${PYTHON_PKGNAMEPREFIX}yaml>=3.10:devel/py-yaml@${PY_FLAVOR} \
-               ${PYTHON_PKGNAMEPREFIX}marshmallow>0:devel/py-marshmallow@${PY_FLAVOR} \
                ${PYTHON_PKGNAMEPREFIX}pytest>0:devel/py-pytest@${PY_FLAVOR} \
+               ${PYTHON_PKGNAMEPREFIX}yaml>=3.10:devel/py-yaml@${PY_FLAVOR}
-               ${PYTHON_PKGNAMEPREFIX}mock>0:devel/py-mock@${PY_FLAVOR}

 # tests_require = prance[osv]>=0.11
+TEST_DEPENDS+= ${PYTHON_PKGNAMEPREFIX}openapi-spec-validator>0:devel/py-openapi-spec-validator@${PY_FLAVOR} \
+               ${PYTHON_PKGNAMEPREFIX}prance>=0.11:devel/py-prance@${PY_FLAVOR}
-TEST_DEPENDS+= ${PYTHON_PKGNAMEPREFIX}prance>=0.11:devel/py-prance@${PY_FLAVOR} \
-               ${PYTHON_PKGNAMEPREFIX}openapi-spec-validator>0:devel/py-openapi-spec-validator@${PY_FLAVOR}
Comment 4 Goran Mekić 2021-10-12 08:00:38 UTC 
Created attachment 228617 [details]
apispec.diff

I didn't know portfmt even exists. Such a great too, thank you!
Comment 5 commit-hook freebsd_committer freebsd_triage 2021-10-12 08:26:57 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c00e76d78d04e08042d8aff5e644362aad13d701

commit c00e76d78d04e08042d8aff5e644362aad13d701
Author:     Goran Mekić <meka@tilda.center>
AuthorDate: 2021-10-12 08:21:30 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2021-10-12 08:25:47 +0000

    devel/py-apispec: Update to 5.1.1

    ChangeLog:
    https://github.com/marshmallow-code/apispec/blob/5.1.1/CHANGELOG.rst

    PR:             259061

 devel/py-apispec/Makefile | 12 ++++++------
 devel/py-apispec/distinfo |  6 +++---
 2 files changed, 9 insertions(+), 9 deletions(-)
Comment 6 Nuno Teixeira freebsd_committer freebsd_triage 2021-10-12 08:36:27 UTC 
Hello Goran,

portlint, portclippy and portfmt are just helpers tools that we should do not follow blindly. They are great at simple things like put some order in Makefile blocks, alphabetical order in some variables lists, etc. Sometimes they help, other times we need a personal look into it.

Committed thanks!

Cheers