Bug 259122 - irc/irssi-xmpp: unbreak following irssi 1.2 downgrade
Summary: irc/irssi-xmpp: unbreak following irssi 1.2 downgrade
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Neel Chauhan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-10-13 01:31 UTC by Thibault Jouan
Modified: 2022-08-02 11:18 UTC (History)
3 users (show)

See Also:

Attachments
unbreak irssi-xmpp (803 bytes, patch)
2021-10-13 01:31 UTC, Thibault Jouan 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thibault Jouan 2021-10-13 01:31:12 UTC 
Created attachment 228642 [details]
unbreak irssi-xmpp

It was marked as broken in commit 3a5380b7 because it did not build
with irc/irssi 1.3. However, irssi was later reverted to version 1.2
(commit 10cd3507) and it builds again since then.

  Thanks!
Comment 1 Thibault Jouan 2022-06-28 11:02:48 UTC 
Is there anything I can do to make any progress on this PR?
Comment 2 Herbert J. Skuhra 2022-06-28 14:01:23 UTC 
Yes, fix irssi-xmpp! :-)

I guess "irc/irssi" should/will be updated to version 1.4.1 (released two weeks ago) soon and then this port will probably break again. Is irssi-xmpp abandonware? Last release is from October, 2017 and the latest commit is from November, 2019.
Comment 3 Neel Chauhan freebsd_committer freebsd_triage 2022-06-28 16:03:22 UTC 
Committed!
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-06-28 16:04:10 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=be7ecf8313a3abfffb22b126fdb7b8c72282ab2c

commit be7ecf8313a3abfffb22b126fdb7b8c72282ab2c
Author:     Thibault Jouan <tj+freebsd_ports@a13.fr>
AuthorDate: 2022-06-28 15:51:27 +0000
Commit:     Neel Chauhan <nc@FreeBSD.org>
CommitDate: 2022-06-28 16:03:16 +0000

    irc/irssi-xmpp: unbreak following irssi 1.2 downgrade

    PR:     259122

 irc/irssi-xmpp/Makefile | 2 --
 1 file changed, 2 deletions(-)
Comment 5 Daniel Engberg freebsd_committer freebsd_triage 2022-06-28 17:26:55 UTC 
This will break soon since upstream is at 1.4.1
Comment 6 Daniel Engberg freebsd_committer freebsd_triage 2022-07-18 19:45:12 UTC 
Just a heads up, it seems like you can unbreak this

https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/36518

I'd suggest that you try to import PRs as commits like in https://cgit.freebsd.org/ports/commit/irc/irssi?id=bc97cc7b70dea8f491605a7670932805dcb9ea97

Sources:
https://github.com/cdidier/irssi-xmpp/pulls

Submit patch in a new PR
Comment 7 Thibault Jouan 2022-08-02 11:18:44 UTC 
Thanks to everyone for tips and info provided, and of course for the commit.

I'm sorry it gave temporary work, and for the delay in working on a proper fix.


(In reply to Daniel Engberg from comment #6)

I followed those suggestions the best I could, and submitted my attempt as bug #265571.