Created attachment 228684 [details] x11-servers/xorg-server: fix build on riscv64 With this patch I was able to build x11-servers/xorg-server on a patched riscv64 FreeBSD 13-STABLE. I cannot test if it builds and works on vanilla riscv64. The patch basically tells the build system to use the IO access setup code from ARM for RISC-V, too. It seems to work and I can start an X server (but didn't get a picture due to a configuration issue it seems). Needs additional QA. Related to bug #259158 and bug #259159.
If any of the related issues (or this one) should be committed prior to others, please add them to the relevent Depends On or Blocks fields in the order in which they should be addressed. Thanks Robert!
No objections to this from me. I have no way of testing on risc-V however.
Comment on attachment 228684 [details] x11-servers/xorg-server: fix build on riscv64 maintainer timeout
I'm not sure what you mean with maintainer timeout. I have approved the PR, and did so resonably fast. Unfortunately I have not had the possibility to get the PR into the ports tree, but I'll see if I can get that done as well.
(In reply to Niclas Zeising from comment #4) Hi Niclas, You didn't set the maintainer approval flag or set the status of the bug to "in progress" or anything, so I'm not sure what you intended to do or if you simply forgot about the PR. By setting the maintainer-approval flag myself (in accordance to ports policy), I intend to move the patch forwards so it can be committed by any committer. If you intend to commit it yourself, please self-assign this bug and set the status to "in progress" or similar.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=191c27eadbff1ca5e93b5fda4154f1182dea49ac commit 191c27eadbff1ca5e93b5fda4154f1182dea49ac Author: Piotr Kubaj <pkubaj@FreeBSD.org> AuthorDate: 2022-01-17 15:01:46 +0000 Commit: Piotr Kubaj <pkubaj@FreeBSD.org> CommitDate: 2022-01-17 15:03:03 +0000 x11-servers/xorg-server: fix build on risc64 Submitted by: fuz@fuz.su Approved by: x11 (maintainer timeout) PR: 259160 x11-servers/xorg-server/files/configure.ac | 2 +- x11-servers/xorg-server/files/patch-configure | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
I'm not sure what happened here, but for the record, I approved this PR at least two times, so it was definitely not maintainer timeout. However, as I stated, I had no riscv64 hardware to test on myself. Thanks for getting it in in the end.
(In reply to Niclas Zeising from comment #7) Hi Niclas, You never set the “maintainer-approval” field on the attachment to indicate your approval. Because of this lack of tagging, nobody knew that you had approved of the patch.
(In reply to Robert Clausecker from comment #8) Comment #2 should have been taken as initial approval. It's not really Niclas' fault that the maintainer- flags in bugzilla are both reasonably annoying and confusing.
I set maintainer timeout not because of the lack of the flag, but because the provided patch wasn't committed timely and the submitter is not a committer, so he couldn't have done it himself. BTW, even if one can't do runtime testing, it's possible to do build test via qemu user.