Bug 259533 - devel/kyua: Correct UCL in pkg-message
Summary: devel/kyua: Correct UCL in pkg-message
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Julio Merino,+1 347 694 0576,New York City
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-10-29 17:37 UTC by Dan Langille
Modified: 2023-11-03 12:09 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (jmmv)


Attachments
Corrects the broken UCL in pkg-message (656 bytes, patch)
2021-10-29 17:37 UTC, Dan Langille
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dan Langille freebsd_committer freebsd_triage 2021-10-29 17:37:16 UTC
Created attachment 229126 [details]
Corrects the broken UCL in pkg-message

The existing UCL is invalid (see below)

The patch assumes you want the same message on install and upgrade. I am not sure that is the intent.

Unpatched:

[pkg01 dan /usr/local/poudriere/ports/default] % /usr/local/bin/ucl_tool --format json --in devel/kyua/pkg-message
Failed to parse input file: error while parsing <unknown>: line: 15, column: 0 - 'unexpected terminating symbol detected', character: '}'



Patched:

[pkg01 dan ~/ports/head] % /usr/local/bin/ucl_tool --format json --in devel/kyua/pkg-message
[
    {
        "type": [
            "install",
            "upgrade"
        ],
        "maximum_version": "0.13_5,3",
        "message": "A tests group has been added and the tests user should be a member\nof it by default rather than nobody. You should update your password\ndatabase to match (change the group from 65534 to 977 after updating).\n\nTo do it, please run the following command:\n\npw usermod -n tests -g tests"
    }
]
Comment 1 Dan Langille freebsd_committer freebsd_triage 2023-07-19 11:34:54 UTC
maintainer timeout.
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-11-03 12:01:20 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=0cc58ed59d3b6e0f8026f4b93c0d7d1e6dd194bc

commit 0cc58ed59d3b6e0f8026f4b93c0d7d1e6dd194bc
Author:     Dan Langille <dvl@FreeBSD.org>
AuthorDate: 2023-11-03 11:46:58 +0000
Commit:     Dan Langille <dvl@FreeBSD.org>
CommitDate: 2023-11-03 12:00:08 +0000

    */*: Fix broken UCL

    Most of this is a missing ] or }. In one case, it was leading
    whitespace before a EOM tag.

    PR:             259533
    Approved by:    portmgr (blanket)

 databases/mariadb1011-server/files/pkg-message.in | 2 +-
 databases/mariadb105-server/files/pkg-message.in  | 2 +-
 databases/mariadb106-server/files/pkg-message.in  | 2 +-
 devel/kyua/pkg-message                            | 2 +-
 editors/vim/pkg-message                           | 2 +-
 misc/openhab/files/pkg-message.in                 | 1 +
 www/minio/pkg-message                             | 1 +
 7 files changed, 7 insertions(+), 5 deletions(-)
Comment 3 Dan Langille freebsd_committer freebsd_triage 2023-11-03 12:09:33 UTC
This came up today when editors/vim was reported to me over IRC - I went looking for the same error message on other ports.

For the record, such errors manifest themselves in FreshPorts as:

pkg-message:
ERROR
WARNING: The FreshPorts parser failed.  ucl_tool failed.  Please report this.