Bug 259563 - graphics/mesa-devel: bump LLVM_DEFAULT to latest as recommend by inline comment
Summary: graphics/mesa-devel: bump LLVM_DEFAULT to latest as recommend by inline comment
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jan Beich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-10-31 02:18 UTC by Ghost
Modified: 2022-08-14 15:11 UTC (History)
1 user (show)

See Also:
jbeich: maintainer-feedback+
jbeich: merge-quarterly-


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Jan Beich freebsd_committer freebsd_triage 2021-10-31 03:41:26 UTC
Fair point. www/firefox already uses devel/llvm13. However, llvm13 is 2x larger than llvm12 and often not installed by package-only users. Possible solutions are STATIC_LLVM (-Dshared-llvm=false) option (a la bug 242607) or flavors for each supported llvm*. The latter is complicated by having to choose the default flavor for a non-suffixed package name and mesa-dri not supporting flavors.

mesa-devel on 2021Q4 is frozen due to Intel/Vulkan regressions (yuzu init, mpv flickering) in later snapshots but switching to llvm13 without updating may regress AMD/OpenGL.
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-01-18 11:40:11 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=dbffec6ff59457e560af66bc0eeb50d6a891d437

commit dbffec6ff59457e560af66bc0eeb50d6a891d437
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2022-01-18 10:47:20 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2022-01-18 11:39:10 +0000

    graphics/mesa-devel: bump local LLVM_DEFAULT after e9669c2a0b41

    PR:             259563

 graphics/mesa-devel/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-01-18 11:40:12 UTC
A commit in branch 2022Q1 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e27e395af387f7483690199f93cefdcbbcaee051

commit e27e395af387f7483690199f93cefdcbbcaee051
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2022-01-18 10:47:20 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2022-01-18 11:39:36 +0000

    graphics/mesa-devel: bump local LLVM_DEFAULT after e9669c2a0b41

    PR:             259563
    (cherry picked from commit dbffec6ff59457e560af66bc0eeb50d6a891d437)

 graphics/mesa-devel/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Comment 4 Ghost 2022-08-14 02:16:42 UTC
# keep in sync with graphics/mesa-dri

Awkward that I put it into TODO and forgot until now.
Comment 5 commit-hook freebsd_committer freebsd_triage 2022-08-14 09:41:54 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=054c92ece4d301a1e8e4f32779389c622ab0d56f

commit 054c92ece4d301a1e8e4f32779389c622ab0d56f
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2022-08-14 09:25:35 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2022-08-14 09:40:45 +0000

    graphics/mesa-devel: restore LLVM_DEFAULT comment before e502b6db284d

    - mesa-dri uses llvm13 but upstream minimum is still llvm11
    - intel-graphics-compiler is flavored for multiple llvm

    PR:             259563

 graphics/mesa-devel/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 6 commit-hook freebsd_committer freebsd_triage 2022-08-14 10:45:03 UTC
A commit in branch 2022Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=d8ba138c728787b000f7304f1923f40a3eed9476

commit d8ba138c728787b000f7304f1923f40a3eed9476
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2022-08-14 09:25:35 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2022-08-14 10:40:21 +0000

    graphics/mesa-devel: restore LLVM_DEFAULT comment before e502b6db284d

    - mesa-dri uses llvm13 but upstream minimum is still llvm11
    - intel-graphics-compiler is flavored for multiple llvm

    PR:             259563
    (cherry picked from commit 054c92ece4d301a1e8e4f32779389c622ab0d56f)

 graphics/mesa-devel/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 7 Ghost 2022-08-14 15:11:20 UTC
(In reply to commit-hook from comment #5)

Thanks. While unrelated, may I ask to also check PR 265828 and PR 265829 ?
Feel free to not, as I know the two are unrelated. No more such requests.