Bug 259586 - mail/mls: Fix build on FreeBSD 13/14, Level up ports compliance
Summary: mail/mls: Fix build on FreeBSD 13/14, Level up ports compliance
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Robert Clausecker
URL:
Keywords: needs-patch, needs-qa
Depends on:
Blocks:
 
Reported: 2021-11-01 09:37 UTC by Robert Clausecker
Modified: 2023-02-14 20:27 UTC (History)
3 users (show)

See Also:
fuz: merge-quarterly?


Attachments
mail/mls: improve and unbreak with -fno-common (7.30 KB, patch)
2021-11-01 09:37 UTC, Robert Clausecker
fuz: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Clausecker freebsd_committer freebsd_triage 2021-11-01 09:37:16 UTC
Created attachment 229185 [details]
mail/mls: improve and unbreak with -fno-common

mail/mls: improve and unbreak with -fno-common

 - liberally sprinkle extern all over the place
 - define LICENSE
 - take over maintainership of this unmaintained port
 - ship examples and html files
 - define DOCS and EXAMPLES options
 - pacify portlint
 - add a pkg-message as the author intended

Tested with Poudriere on armv7 arm64 FreeBSD 13.
Please MFH if possible.
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2021-11-01 11:03:41 UTC
http://marki.host.sk/MLS/ in MASTER_SITES is dead
Given that it hasn't been touched in 15+ years does it actually work as intended? The PHP part on the site at least errors out ( http://www.marki-online.net/MLS/demo/mls.php ) and I would guess that it's also the same in the package
Comment 2 Robert Clausecker freebsd_committer freebsd_triage 2021-11-01 12:00:25 UTC
(In reply to Daniel Engberg from comment #1)

Hi Daniel,

I can confirm that the port still works and produces mail statistics just fine.

As for the PHP part, I have not and cannot test it.  Feel free to test it yourself if you like.

If you commit this change, feel free to leave the dead MASTER_SITES entry out.
Comment 3 Robert Clausecker freebsd_committer freebsd_triage 2022-12-07 11:35:46 UTC
otis@ has informed upstream about the -fno-common related errors.  Upstream may release a new version to fix these.
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-02-14 20:24:22 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=342a19d2da54e08fc124722bf9d91b75303582df

commit 342a19d2da54e08fc124722bf9d91b75303582df
Author:     Robert Clausecker <fuz@FreeBSD.org>
AuthorDate: 2023-02-09 15:20:28 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-02-14 20:18:57 +0000

    mail/mls: improve and unbreak with -fno-common

     - liberally sprinkle extern all over the place
     - define LICENSE
     - take over maintainership of this unmaintained port
     - ship examples and html files
     - define DOCS and EXAMPLES options
     - pacify portlint and portclippy
     - add a pkg-message as the author intended
     - remove dead MASTER_SITES entry

    PR:             259586
    Approved by:    flo (mentor)
    Differential Revision: https://reviews.freebsd.org/D38516

 mail/mls/Makefile                      | 38 +++++++++++++++++++++++++++-------
 mail/mls/distinfo                      |  1 +
 mail/mls/files/patch-Makefile          |  7 +++----
 mail/mls/files/patch-mls.c (new)       | 19 +++++++++++++++++
 mail/mls/files/patch-mls.h             | 13 ++++++++++--
 mail/mls/files/patch-mls__mime.h (new) | 11 ++++++++++
 mail/mls/files/patch-mls_text.c        |  4 ++--
 mail/mls/files/patch-mls_text.h        |  6 +++---
 mail/mls/files/pkg-message.in (new)    |  6 ++++++
 9 files changed, 86 insertions(+), 19 deletions(-)