Bug 259615 - math/gkmap: patch and unbreak with -fno-common
Summary: math/gkmap: patch and unbreak with -fno-common
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Hiroki Tagato
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-11-02 16:29 UTC by Robert Clausecker
Modified: 2021-12-08 04:55 UTC (History)
2 users (show)

See Also:
fuz: maintainer-feedback-
fuz: merge-quarterly?

Attachments
math/gkmap: patch and unbreak with -fno-common (2.63 KB, patch)
2021-11-02 16:29 UTC, Robert Clausecker 		fuz: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Clausecker freebsd_committer freebsd_triage 2021-11-02 16:29:57 UTC 
Created attachment 229226 [details]
math/gkmap: patch and unbreak with -fno-common

This fixes math/gkmap on FreeBSD 13 and 14 where -fno-common is a default option to the C compiler.

Also add a missing dependency on libharfbuzz while we are at it.

Tested with Poudriere on armv7 arm64 FreeBSD 13.
Comment 1 Robert Clausecker freebsd_committer freebsd_triage 2021-11-19 13:35:01 UTC 
Comment on attachment 229226 [details]
math/gkmap: patch and unbreak with -fno-common

maintainer timeout
Comment 2 Robert Clausecker freebsd_committer freebsd_triage 2021-11-30 17:43:39 UTC 
maintainer timeout
Comment 3 Hiroki Tagato freebsd_committer freebsd_triage 2021-12-08 04:54:49 UTC 
Committed, thanks!
Comment 4 commit-hook freebsd_committer freebsd_triage 2021-12-08 04:55:05 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=975c082fd1c451a3ad276e398df7eb4c60698b02

commit 975c082fd1c451a3ad276e398df7eb4c60698b02
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2021-12-08 04:52:35 +0000
Commit:     Hiroki Tagato <tagattie@FreeBSD.org>
CommitDate: 2021-12-08 04:54:03 +0000

    math/gkmap: fix build with -fno-common

    PR:             259615
    Approved by:    javad.kouhi@gmail.com (maintainer timeout, 5 weeks)

 math/gkmap/Makefile                             |  8 +++-----
 math/gkmap/files/patch-src_init.c (new)         | 14 +++++++++++++
 math/gkmap/files/patch-src_kmap__struct.h (new) | 26 +++++++++++++++++++++++++
 3 files changed, 43 insertions(+), 5 deletions(-)