Bug 259740 - net/freerdp: Fails to build with libressl 3.4.1
Summary: net/freerdp: Fails to build with libressl 3.4.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-ports-bugs (Nobody)
URL: https://github.com/FreeRDP/FreeRDP/pu...
Keywords:
Depends on:
Blocks:
 
Reported: 2021-11-09 16:54 UTC by Ivan Rozhuk
Modified: 2021-12-26 18:44 UTC (History)
3 users (show)

See Also:
vvd: maintainer-feedback+


Attachments
pa (973 bytes, patch)
2021-11-09 17:35 UTC, Ivan Rozhuk
no flags Details | Diff
patch (1.52 KB, patch)
2021-11-09 20:37 UTC, Ivan Rozhuk
no flags Details | Diff
Patch to the ports tree with update patch commit (2.24 KB, patch)
2021-12-22 21:15 UTC, Fernando Apesteguía
fernape: maintainer-approval?
Details | Diff
Fix patch check sum (685 bytes, patch)
2021-12-26 12:41 UTC, Vladimir Druzenko
vvd: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ivan Rozhuk 2021-11-09 16:54:02 UTC
FAILED: libfreerdp/CMakeFiles/freerdp.dir/crypto/tls.c.o 
/usr/local/bin/ccache /usr/local/libexec/ccache/cc -DCMAKE_BUILD_TYPE=Release -DEXT_PATH=\"/usr/local/lib/freerdp2/extensions\" -DFREERDP_EXPORTS -DHAVE_CONFIG_H -DSWSCALE_FOUND=1 -DWINPR_EXPORTS -DWITH_OPENSSL -DWITH_X11 -DWITH_XKBFILE -D_FILE_OFFSET_BITS=64 -Dfreerdp_EXPORTS -I/tmp/ports/usr/ports/net/freerdp/work/.build -I/tmp/ports/usr/ports/net/freerdp/work/.build/include -I/tmp/ports/usr/ports/net/freerdp/work/freerdp-2.4.1/include -I/tmp/ports/usr/ports/net/freerdp/work/freerdp-2.4.1/winpr/include -I/tmp/ports/usr/ports/net/freerdp/work/.build/winpr/include -O2 -pipe -O3 -pipe -funroll-loops -DSTRIP_FBSDID -D_FORTIFY_SOURCE=2 -mretpoline  -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing  -fdebug-prefix-map=/tmp/ports/usr/ports/net/freerdp/work/freerdp-2.4.1=. -Wno-unused-parameter -Wno-unused-macros -Wno-padded -Wno-c11-extensions -Wno-gnu -Wno-unused-command-line-argument -Wno-deprecated-declarations -fno-omit-frame-pointer -DWINPR_DLL -O2 -pipe -O3 -pipe -funroll-loops -DSTRIP_FBSDID -D_FORTIFY_SOURCE=2 -mretpoline  -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing  -fdebug-prefix-map=/tmp/ports/usr/ports/net/freerdp/work/freerdp-2.4.1=. -fPIC -MD -MT libfreerdp/CMakeFiles/freerdp.dir/crypto/tls.c.o -MF libfreerdp/CMakeFiles/freerdp.dir/crypto/tls.c.o.d -o libfreerdp/CMakeFiles/freerdp.dir/crypto/tls.c.o -c /tmp/ports/usr/ports/net/freerdp/work/freerdp-2.4.1/libfreerdp/crypto/tls.c
../freerdp-2.4.1/libfreerdp/crypto/tls.c:355:13: error: incomplete definition of type 'struct ssl_st'
                                tls->ssl->wbio = tls->ssl->rbio = NULL;
                                ~~~~~~~~^
/usr/local/include/openssl/ossl_typ.h:160:16: note: forward declaration of 'struct ssl_st'
typedef struct ssl_st SSL;
               ^
../freerdp-2.4.1/libfreerdp/crypto/tls.c:355:30: error: incomplete definition of type 'struct ssl_st'
                                tls->ssl->wbio = tls->ssl->rbio = NULL;
                                                 ~~~~~~~~^
/usr/local/include/openssl/ossl_typ.h:160:16: note: forward declaration of 'struct ssl_st'
typedef struct ssl_st SSL;
               ^
2 errors generated.
Comment 1 Ivan Rozhuk 2021-11-09 17:35:19 UTC
Created attachment 229382 [details]
pa
Comment 2 Vladimir Druzenko freebsd_committer freebsd_triage 2021-11-09 19:38:24 UTC
Have you suggested this patch to upstream?
Comment 3 Ivan Rozhuk 2021-11-09 20:37:16 UTC
Created attachment 229393 [details]
patch

They already have another one patch in base: https://github.com/FreeRDP/FreeRDP/pull/7033
Comment 4 Vladimir Druzenko freebsd_committer freebsd_triage 2021-11-09 21:01:33 UTC
Commit from May is not in release 2.4.1 from October - weird.
Comment 5 Vladimir Druzenko freebsd_committer freebsd_triage 2021-11-13 19:30:56 UTC
(In reply to Ivan Rozhuk from comment #3)
Upstream ask for pull request to stable-2.0.
Comment 6 Vladimir Druzenko freebsd_committer freebsd_triage 2021-11-17 10:15:04 UTC
This commit is for branch stable-2.0:
https://github.com/FreeRDP/FreeRDP/commit/bfbef39759b9641a4fab8b75b9243c48cb0789ac

Replace please commit in Makefile and I'll approve patch. Thanks.
Comment 7 Fernando Apesteguía freebsd_committer freebsd_triage 2021-12-22 21:15:07 UTC
Created attachment 230323 [details]
Patch to the ports tree with update patch commit

Updated patch with the suggested commit.

Also some minor improvements regarding ordering of the variables in the Makefile.
Comment 8 Vladimir Druzenko freebsd_committer freebsd_triage 2021-12-22 22:16:33 UTC
Comment on attachment 230323 [details]
Patch to the ports tree with update patch commit

Look good for me.
Thanks!
Comment 9 commit-hook freebsd_committer freebsd_triage 2021-12-23 09:53:30 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=fc6db685f4ad53d532982cbce840f29290970193

commit fc6db685f4ad53d532982cbce840f29290970193
Author:     Fernando Apesteguía <fernape@FreeBSD.org>
AuthorDate: 2021-12-22 16:35:38 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2021-12-23 09:51:08 +0000

    net/freerdp: Fix build with libressl 3.4.1

    Apply patch from:
    https://github.com/FreeRDP/FreeRDP/commit/bfbef39759b9641a4fab8b75b9243c48cb0789ac

    While here, pet linters.

    PR:     259740
    Reported by:    rozhuk.im@gmail.com
    Approved by:    vvd@unislabs.com (maintainer)

 net/freerdp/Makefile | 12 ++++++++----
 net/freerdp/distinfo |  4 +++-
 2 files changed, 11 insertions(+), 5 deletions(-)
Comment 10 Fernando Apesteguía freebsd_committer freebsd_triage 2021-12-23 09:53:55 UTC
Committed,

Thanks!
Comment 11 Vladimir Druzenko freebsd_committer freebsd_triage 2021-12-26 12:41:38 UTC
Created attachment 230421 [details]
Fix patch check sum

Don't know why, but patch from github changed in size.
Comment 12 commit-hook freebsd_committer freebsd_triage 2021-12-26 18:43:14 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b7a6b250ed8795e43c7c0efc4c3708093aff8c34

commit b7a6b250ed8795e43c7c0efc4c3708093aff8c34
Author:     Fernando Apesteguía <fernape@FreeBSD.org>
AuthorDate: 2021-12-26 15:19:37 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2021-12-26 18:40:52 +0000

    net/freerdp: recalculate checksum for patch.

    For some reason, the patch in GH changed its size:

    => Attempting to fetch https://github.com/FreeRDP/FreeRDP/commit/bfbef39759b9641a4fab8b75b9243c48cb0789ac.patch
    fetch: https://github.com/FreeRDP/FreeRDP/commit/bfbef39759b9641a4fab8b75b9243c48cb0789ac.patch:
    size mismatch: expected 2184, actual 2186

    PR:     259740
    Reported by:    vvd@unislabs.com (maintainer)

 net/freerdp/distinfo | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Comment 13 Fernando Apesteguía freebsd_committer freebsd_triage 2021-12-26 18:44:32 UTC
Done.

Thanks!