Bug 259753 - xdm should depend on xsm for not returning to loging screen just after login if no .xsession file
Summary: xdm should depend on xsm for not returning to loging screen just after login ...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Kevin Bowling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-11-10 12:16 UTC by Paul Dufresne
Modified: 2023-08-12 21:06 UTC (History)
2 users (show)

See Also:
kbowling: maintainer-feedback+


Attachments
allows to login without .xsession by run-depending on xsm (322 bytes, patch)
2023-02-20 00:57 UTC, Paul Dufresne
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Dufresne 2021-11-10 12:16:28 UTC
I installed from:
https://download.freebsd.org/ftp/snapshots/amd64/amd64/ISO-IMAGES/14.0/FreeBSD-14.0-CURRENT-amd64-20211104-7ac82c96fe7-250453-disc1.iso.xz

After that I installed xdm (following section 5.6 of the handbook.

After rebooting, when I was logging with the right password, it would return immediately to the logging screen with no apparent errors.

I discovered that the file:
/usr/local/etc/X11/xdm/Xsession have inside it:

f [ -s "$startup" ]; then
	if [ -x "$startup" ]; then
		exec "$startup"
	else
		exec /bin/sh "$startup"
	fi
else
	if [ -r "$resources" ]; then
		/usr/local/bin/xrdb -load "$resources"
	fi
	exec /usr/local/bin/xsm
fi

And so I needed to install X11/xsm (X session manager) with "pkg install X11/xsm".

After doing so, and rebooted, I was able to boot with xdm... although the environment I was put it surprised me a bit, but from there it did not took look for me to edit .xsession to log in with my wanted desktop environment.
Comment 1 Paul Dufresne 2023-02-20 00:57:10 UTC
Created attachment 240267 [details]
allows to login without .xsession by run-depending on xsm

portling WARN: Makefile: extra item placed in the *_DEPENDS section, for example, "EXTRACT_SUFX".

This is my first submitted patch. (so a bit unsure about format)
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-08-12 21:06:30 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=48aa973349e841b5743256c0023cc10d3ba2f356

commit 48aa973349e841b5743256c0023cc10d3ba2f356
Author:     Paul Dufresne <dufresnep@zoho.com>
AuthorDate: 2023-08-12 21:02:22 +0000
Commit:     Kevin Bowling <kbowling@FreeBSD.org>
CommitDate: 2023-08-12 21:02:22 +0000

    x11/xdm: Add runtime dependency on xsm

    PR:             259753

 x11/xdm/Makefile | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)