Bug 259812 - audio/audacity upgrade to to 3.1.1
Summary: audio/audacity upgrade to to 3.1.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Rainer Hurling
URL: https://www.audacityteam.org/audacity...
Keywords:
Depends on:
Blocks:
 
Reported: 2021-11-13 05:50 UTC by Jack
Modified: 2021-11-15 06:01 UTC (History)
3 users (show)

See Also:
xxjack12xx: maintainer-feedback+


Attachments
Upgrade to audacity 3.1.1 (2.64 KB, patch)
2021-11-13 05:50 UTC, Jack
xxjack12xx: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jack 2021-11-13 05:50:22 UTC
Created attachment 229464 [details]
Upgrade to audacity 3.1.1
Comment 1 commit-hook freebsd_committer freebsd_triage 2021-11-14 20:32:50 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=6f050c504f7193f676f9670a137be71352716a65

commit 6f050c504f7193f676f9670a137be71352716a65
Author:     Jack <xxjack12xx@gmail.com>
AuthorDate: 2021-11-14 20:31:05 +0000
Commit:     Rainer Hurling <rhurlin@FreeBSD.org>
CommitDate: 2021-11-14 20:31:05 +0000

    audio/audacity: Update to 3.1.1

    Hotfix release [1]:
    - Fixed FFMPEG imports only importing the left channel
    - Improved Audacity's performance when many clips are present
    - Fixed a crash with detach at silences
    - Fixed clip name corruption when applying effects to adjacent clips
    - Fixed a crash with the time shift commands
    - Fixed custom themes not working

    [1] https://github.com/audacity/audacity/releases/tag/Audacity-3.1.1

    PR:             259812

 audio/audacity/Makefile                                       |  2 +-
 audio/audacity/distinfo                                       |  6 +++---
 .../files/patch-cmake-proxies_libsoxr_CMakeLists.txt (gone)   | 10 ----------
 .../files/patch-lib-src_portmixer_CMakeLists.txt (gone)       | 11 -----------
 4 files changed, 4 insertions(+), 25 deletions(-)
Comment 2 Rainer Hurling freebsd_committer freebsd_triage 2021-11-14 20:37:19 UTC
Hi Jack,

Thanks for the patch, committed ;) Because this is a hotfix release [1], I mentioned it in the commit.

[1] https://github.com/audacity/audacity/releases/tag/Audacity-3.1.1


Two notes:

Your patch contains msdos-like line endings:
#file 259812/229464-audacity.txt 
259812/229464-audacity.txt: unified diff output, ASCII text, with CRLF line terminators.

Your patch could not be applied, I had to patch it manually. Please make sure you use the correct format next time, preferably something like 'git format-patch'.
Comment 3 Jack 2021-11-14 21:48:04 UTC
(In reply to Rainer Hurling from comment #2)
I'm not sure why it keeps doing that, when I created the patch it had to msdos lines. Maybe it was because I ftp'd it to a windows PC to upload? Will double check next time, thanks.
Comment 4 Jack 2021-11-14 21:56:11 UTC
(In reply to Jack from comment #3)
had no msdos*
Comment 5 Tatsuki Makino 2021-11-15 06:01:55 UTC
These days, it is always better to use binary mode for FTP, since we are mostly not bothered by LF on Windows.
For FreeBSD FTP(1), "type binary" or "quote type i" can be used.
In addition, recent Windows 10 can also use OpenSSH ssh and scp :)