Bug 259908 - audio/logitechmediaserver: Update to 8.2
Summary: audio/logitechmediaserver: Update to 8.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Fernando Apesteguía
URL: https://github.com/Logitech/slimserve...
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2021-11-18 06:19 UTC by david
Modified: 2022-11-06 18:49 UTC (History)
5 users (show)

See Also:


Attachments
path to upgrade to LMS 8.2 (68.45 KB, patch)
2021-11-18 06:19 UTC, david
no flags Details | Diff
Reworked patch (168.07 KB, patch)
2022-09-20 09:46 UTC, Fernando Apesteguía
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description david 2021-11-18 06:19:39 UTC
Created attachment 229564 [details]
path to upgrade to LMS 8.2

This upgrades logitechmediaserver to 8.2; I am running this on amd64 successfully, I removed i386 as a supported platform because I don't have the ability to easily and compile on that; it *should* work with updated paths and conditionals in the pkg-plist.

Also updated the pkg-message with notes on using this with older devices.

I have NOT tested the other logitechmediaserver-FOO companion ports that appear to be plugins.  They probably work as is though
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2021-11-19 06:57:00 UTC
^Triage: [tags] in issue Titles are deprecated.
^Triage: If there is a changelog or release notes URL available for this version, please add it to the URL field.
Comment 2 david 2021-11-21 07:04:43 UTC
https://github.com/Logitech/slimserver/blob/public/8.2/Changelog8.html

That's in git for the changelog, but it doesn't render as HTML in a browser; not sure if there's a 'magic' way to do that
Comment 3 Fernando Apesteguía freebsd_committer freebsd_triage 2021-11-21 17:41:04 UTC
(In reply to david from comment #2)
It is best than nothing.

Thanks!
Comment 4 Poul-Henning Kamp freebsd_committer freebsd_triage 2022-09-18 05:59:00 UTC
I just tried this patch and it works for me on amd64.

I had to edit the PORTVERSION field in Makefile manually because patch(1) rejected that edit.

Can we please have this port updated now, it has been broken forever...
Comment 5 Fernando Apesteguía freebsd_committer freebsd_triage 2022-09-19 11:02:18 UTC
(In reply to Poul-Henning Kamp from comment #4)
Sorry, but the update is not ready:

====> Running Q/A tests (stage-qa)
Warning: Symlink '/usr/local/share/logitechmediaserver/Cache' pointing to '/var/db/logitechmediaserver/cache' which does not exist in the stage directory or in localbase
Notice: You have some Perl modules as dependencies but you do not have devel/p5-Module-CoreList installed, the perlcore QA check gets better results when using it, especially with older Perl versions.
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: %%SLIMDIR%%/Cache
Error: Orphaned: @dir %%SLIMDIR%%/Bin
Error: Orphaned: @dir %%SLIMDIR%%/CPAN/arch/%%PERL_VER%%/%%ARCHNAME%%/auto/Audio/Cuefile/Parser
Error: Orphaned: @dir %%SLIMDIR%%/CPAN/arch/%%PERL_VER%%/%%ARCHNAME%%/auto/Data/Dump
Error: Orphaned: @dir %%SLIMDIR%%/CPAN/arch/%%PERL_VER%%/%%ARCHNAME%%/auto/ExtUtils/CBuilder
Error: Orphaned: @dir %%SLIMDIR%%/CPAN/arch/%%PERL_VER%%/%%ARCHNAME%%/auto/HTML/Tagset
Error: Orphaned: @dir %%SLIMDIR%%/CPAN/arch/%%PERL_VER%%/%%ARCHNAME%%/auto/Module/Build
Error: Orphaned: @dir %%SLIMDIR%%/CPAN/arch/%%PERL_VER%%/%%ARCHNAME%%/auto/Sub/Uplevel
Error: Orphaned: @dir %%SLIMDIR%%/CPAN/arch/%%PERL_VER%%/%%ARCHNAME%%/auto/Test/NoWarnings
Error: Orphaned: @dir %%SLIMDIR%%/CPAN/arch/%%PERL_VER%%/%%ARCHNAME%%/auto/Test/Warn
Error: Orphaned: @dir %%SLIMDIR%%/CPAN/arch/%%PERL_VER%%/%%ARCHNAME%%/auto/Tree/DAG_Node
Error: Orphaned: @dir %%SLIMDIR%%/CPAN/arch/%%PERL_VER%%/%%ARCHNAME%%/auto/YAML/LibYAML
Error: Orphaned: @dir %%SLIMDIR%%/CPAN/arch/%%PERL_VER%%/%%ARCHNAME%%/auto/common/sense

For instance, %%SLIMDIR%%/Cache was explicitly removed from pkg-plist int the patch, but it is generated during installation...
Comment 6 Fernando Apesteguía freebsd_committer freebsd_triage 2022-09-20 09:46:41 UTC
Created attachment 236698 [details]
Reworked patch

This patch builds fine in 12.3{amd64, i386}, 13.1amd64 and 14-current amd64.

Would you mind to run test it? I'm not familiar with the software.

Thanks.
Comment 7 Fernando Apesteguía freebsd_committer freebsd_triage 2022-09-22 10:52:00 UTC
Friendly ping.
Comment 8 Fernando Apesteguía freebsd_committer freebsd_triage 2022-09-27 14:26:20 UTC
Another ping.
Comment 9 Fernando Apesteguía freebsd_committer freebsd_triage 2022-10-04 06:23:45 UTC
Committed,

Thanks!
Comment 10 commit-hook freebsd_committer freebsd_triage 2022-10-04 06:24:06 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8f0e8efc92752afd3be1ae359831ab4829c575b2

commit 8f0e8efc92752afd3be1ae359831ab4829c575b2
Author:     Fernando Apesteguía <fernape@FreeBSD.org>
AuthorDate: 2022-09-19 06:04:32 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2022-10-04 06:19:49 +0000

    audio/logitechmediaserver: Update to 8.2

    ChangeLog:
    https://github.com/Logitech/slimserver/blob/public/8.2/Changelog8.html

    PR:             259908
    Reported by:    david@dcrosstech.com
    Tested by:      phk@

 audio/logitechmediaserver/Makefile                 |   68 +-
 audio/logitechmediaserver/distinfo                 |   10 +-
 .../files/vendorpatch-CPAN_buildme.sh              |    4 +-
 audio/logitechmediaserver/pkg-message              |   15 +
 audio/logitechmediaserver/pkg-plist                |  353 +--
 audio/logitechmediaserver/pkg-plist.i386 (new)     | 2490 ++++++++++++++++++++
 6 files changed, 2751 insertions(+), 189 deletions(-)
Comment 11 Poul-Henning Kamp freebsd_committer freebsd_triage 2022-10-04 06:28:43 UTC
Thanks a LOT!
Comment 12 Eriks Dobelis 2022-10-21 20:51:33 UTC
Building and installing this port in a fresh RELEASE-13.1 jail installs slimserver.pl without execute bit, thus startup script in /usr/local/etc/rc.d/logitechmediaserver fails to start with
run_rc_command: cannot run /usr/local/share/logitechmediaserver/slimserver.pl

After setting execute bit manually (on all .pl files in the /usr/local/share/logitechmediaserver) the service seems to start, but opening http://localhost:9000 returns:
404 Not Found: 

Was this really tested?
Comment 13 David Z. 2022-10-28 00:28:12 UTC
(In reply to Eriks Dobelis from comment #12)
I'm having the same issues.  In addition, he FLAC option, when selected, no longer works (the server states that it cannot play FLAC files even with the FLAC option selected and audio/flac installed).  I e-mailed the committer two weeks ago about these issues with no reply.  This commit needs to be backed out ASAP.
Comment 14 Fernando Apesteguía freebsd_committer freebsd_triage 2022-10-28 10:06:09 UTC
(In reply to Eriks Dobelis from comment #12)
It was reported to work by the OP and another person. It might be they use it differently though.
Comment 15 Fernando Apesteguía freebsd_committer freebsd_triage 2022-10-28 10:07:23 UTC
(In reply to David Z. from comment #13)
That would be me. I have no such email sorry. Not even in spam or trash. I would try and fix this instead of backing it out. Unfortunately the port has no maintainer and that makes things more difficult.

Is anyone able to provide a patch?
Comment 16 David Z. 2022-10-28 14:48:31 UTC
(In reply to Fernando Apesteguía from comment #15)
Bug 242345 has a working patch from Hans Soonieus that was never committed.  That's what I was using before this commit was made.
Comment 17 Fernando Apesteguía freebsd_committer freebsd_triage 2022-11-06 18:49:19 UTC
(In reply to David Z. from comment #16)
I've tried that patch and I'm able to build on amd64 but not in i386. Did you try with both of them?