Bug 259992 - Mk/Scripts/qa.sh: Bogus 'xx doesn't have a SONAME' messages are printed by stage-qa for some shared libraries
Summary: Mk/Scripts/qa.sh: Bogus 'xx doesn't have a SONAME' messages are printed by st...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Yuri Victorovich
URL:
Keywords:
: 265096 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-11-23 02:13 UTC by Yuri Victorovich
Modified: 2022-07-09 14:52 UTC (History)
2 users (show)

See Also:

Attachments
fix-SONAME.patch (1.00 KB, patch)
2021-11-23 02:13 UTC, Yuri Victorovich 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer freebsd_triage 2021-11-23 02:13:01 UTC 
Created attachment 229664 [details]
fix-SONAME.patch

Currently stage-qa prints bogus messages 'xx doesn't have a SONAME' when readelf produces too long output.

Testcase: math/vtk9

All shared libraries instaled by math/vtk9 do have SONAME but the bogus messages about missing SONAME are printed.

Reason: 'grep -q SONAME' ends before it drains the pipe, pipe fails when the remaining output is too long, and 'set -o pipefail' causes the whole command to fail when it is supposed to succeed.

Remedy: Please apply the attached patch fix-SONAME.patch, or alternatively remove 'set -o pipefail' from qa.sh
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2022-07-09 00:06:59 UTC 
*** Bug 265096 has been marked as a duplicate of this bug. ***
Comment 2 Tobias C. Berner freebsd_committer freebsd_triage 2022-07-09 08:37:51 UTC 
Moin moin 

Looks identical to what Fedora suggested here: 
htps://bugzilla.redhat.com/show_bug.ci?id=1589997#c2

So, ship it.


mfg Tobias
Comment 3 Yuri Victorovich freebsd_committer freebsd_triage 2022-07-09 14:52:53 UTC 
Committed, thanks!
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-07-09 14:52:54 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=6af95e9e48b065580cbac3f329e73c2b83e7f02d

commit 6af95e9e48b065580cbac3f329e73c2b83e7f02d
Author:     Yuri Victorovich <yuri@FreeBSD.org>
AuthorDate: 2022-07-09 14:50:47 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2022-07-09 14:52:33 +0000

    Mk/Scripts/qa.sh: Bogus 'xx doesn't have a SONAME' messages are printed by stage-qa for some shared libraries

    Reason: 'grep -q SONAME' ends before it drains the pipe, pipe fails
    when the remaining output is too long, and 'set -o pipefail'
    causes the whole command to fail when it is supposed to succeed.

    Remedy: Please apply the attached patch fix-SONAME.patch, or
    alternatively remove 'set -o pipefail' from qa.sh

    PR:             259992
    Approved by:    tcberner@ (as portmgr)

 Mk/Scripts/qa.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)