Bug 260115 - games/jinput: unbreak on armv6 and armv7
Summary: games/jinput: unbreak on armv6 and armv7
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: arm Any
: --- Affects Only Me
Assignee: Mikael Urankar
URL:
Keywords: easy
Depends on:
Blocks:
 
Reported: 2021-11-29 13:08 UTC by Robert Clausecker
Modified: 2021-12-01 16:51 UTC (History)
2 users (show)

See Also:
mikael: maintainer-feedback+
fuz: merge-quarterly?

Attachments
games/jinput: unbreak on armv6 and armv7 (744 bytes, patch)
2021-11-29 13:08 UTC, Robert Clausecker 		fuz: maintainer-approval? (voidanix)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Clausecker freebsd_committer freebsd_triage 2021-11-29 13:08:45 UTC 
Created attachment 229790 [details]
games/jinput: unbreak on armv6 and armv7

Having tested this port on armv6 (without Poudriere) and armv7 (with Poudriere) FreeBSD 13, I can confirm that it builds just fine.

The attached patch hence removes the BROKEN entries for these two architectures.

Please MFH if possible.
Comment 1 Mikael Urankar freebsd_committer freebsd_triage 2021-11-29 19:41:59 UTC 
No need for maintainer approval, this falls under portmgr blanket approval
https://docs.freebsd.org/en/articles/committers-guide/
Trivial and tested build and runtime fixes.
Comment 2 Robert Clausecker freebsd_committer freebsd_triage 2021-11-29 21:34:46 UTC 
(In reply to Mikael Urankar from comment #1)

You just set the maintainer-feedback flag, not the maintainer-approval flag.  But that said, feel free to commit this patch if you have time.
Comment 3 commit-hook freebsd_committer freebsd_triage 2021-12-01 16:48:07 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5c8785ce1cb5eb2d4f361f1af0b18abe99abb6c4

commit 5c8785ce1cb5eb2d4f361f1af0b18abe99abb6c4
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2021-12-01 16:45:26 +0000
Commit:     Mikael Urankar <mikael@FreeBSD.org>
CommitDate: 2021-12-01 16:46:37 +0000

    games/jinput: Unbreak on armv6 and armv7.

    PR:             260115
    Approved by:    portgmr blanket

 games/jinput/Makefile | 3 ---
 1 file changed, 3 deletions(-)
Comment 4 commit-hook freebsd_committer freebsd_triage 2021-12-01 16:48:08 UTC 
A commit in branch 2021Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b5f456d04123a5bbbf0f724472efb6279a06338c

commit b5f456d04123a5bbbf0f724472efb6279a06338c
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2021-12-01 16:45:26 +0000
Commit:     Mikael Urankar <mikael@FreeBSD.org>
CommitDate: 2021-12-01 16:47:36 +0000

    games/jinput: Unbreak on armv6 and armv7.

    PR:             260115
    Approved by:    portgmr blanket

    (cherry picked from commit 5c8785ce1cb5eb2d4f361f1af0b18abe99abb6c4)

 games/jinput/Makefile | 3 ---
 1 file changed, 3 deletions(-)
Comment 5 Mikael Urankar freebsd_committer freebsd_triage 2021-12-01 16:51:49 UTC 
Thanks!