Created attachment 229918 [details] games/freesweep: patch and unbreak with -fno-common See URL for a github issue describing the problem: > When compiling with a sufficiently modern C compiler (one where -fno-common > is the default), linking fails due to a duplicate symbol CharSet. This is > because the global variable CharSet is defined in sweep.h.in which is included > in all sorts of files. While we are at it: - make portlint happy - move scores file to hier(7) directory - fix plist issues and move plist to a plist file - remove --disable-debug-log which had the opposite effect Tested with Poudriere on armv7 arm64 FreeBSD 13.
Waiting for maintainer approval.
Sorry, I had notifications turned off on the upstream repo. I merged this fix upstream and made a new tag v1.0.2 so we don't have to carry the patch here. While you're at it, go ahead and drop me as maintainer here; I don't have time for it anymore and don't want to hold you guys up :(
Cool. Will prepare an updated patch in a minute.
Created attachment 229967 [details] games/freesweep: update to 1.0.2 games/freesweep: update to 1.0.2 While we are at it: - make portlint happy - move scores file to hier(7) directory - fix plist issues and move plist to a plist file - remove --disable-debug-log which had the opposite effect - take over maintainership as requested by previos maintainer Upstream fixes: - always use "%s"-style format for printf()-style functions - fix build with gcc 10 Tested with on armv7 arm64 FreeBSD 13.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=f98f36ad53e5fc2ae72f609f192c957e76dd8071 commit f98f36ad53e5fc2ae72f609f192c957e76dd8071 Author: Robert Clausecker <fuz@fuz.su> AuthorDate: 2021-12-08 08:19:15 +0000 Commit: Juraj Lutter <otis@FreeBSD.org> CommitDate: 2021-12-08 08:19:15 +0000 games/freesweep: update to 1.0.2 Update to 1.0.2 and while we are here: - make portlint happy - move scores file to hier(7) directory - fix plist issues and move plist to a plist file - remove --disable-debug-log which had the opposite effect - pass maintainership to fuz@fuz.su as requested by previous maintainer Upstream fixes: - always use "%s"-style format for printf()-style functions - fix build with gcc 10 PR: 260233 games/freesweep/Makefile | 21 ++++++++------------- games/freesweep/distinfo | 5 +++-- games/freesweep/files/patch-config.h.in | 4 ++-- games/freesweep/pkg-plist (new) | 4 ++++ 4 files changed, 17 insertions(+), 17 deletions(-)
Committed, thanks.