Bug 260255 - misc/free42: fix build on armv7
Summary: misc/free42: fix build on armv7
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-12-06 12:49 UTC by Robert Clausecker
Modified: 2024-01-11 09:16 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (yuri)
fuz: merge-quarterly?


Attachments
misc/free42: fix build on armv7 (6.36 KB, patch)
2021-12-06 12:49 UTC, Robert Clausecker
fuz: maintainer-approval? (yuri)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Clausecker freebsd_committer freebsd_triage 2021-12-06 12:49:24 UTC
Created attachment 229941 [details]
misc/free42: fix build on armv7

The port had originally been patched by extracting the Intel RDFP Math
Library component ahead of time and then patching it.  A recent change
had broken this mechanism, causing all patches to it to be ignored.

Restore the original way this port was built and add a patch to fix an
issue with defining wchar_t.  This makes the port build fine on armv7.

While we are at it, make the build less verbose and add a missing
dependency on harfbuzz.

Tested with Poudriere on i386 amd64 FreeBSD, without Poudriere on armv7 FreeBSD 13 (rust-cbindgen currently doesn't build on armv7, so I cannot test with Poudriere).
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2021-12-06 17:33:04 UTC
Committed, thanks!
Comment 2 commit-hook freebsd_committer freebsd_triage 2021-12-06 17:33:56 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=1d7c16ff2465372af06c92d7c8f92f4a0a718bb2

commit 1d7c16ff2465372af06c92d7c8f92f4a0a718bb2
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2021-12-06 17:31:33 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2021-12-06 17:32:49 +0000

    misc/free42: Fix build on armv7

    PR:             260255

 misc/free42/Makefile                               | 12 +++++++++---
 ...telRDFPMathLib20U1_LIBRARY_src_bid__functions.h | 22 ++++++++++++++++++++--
 misc/free42/files/patch-gtk_build-intel-lib.sh     | 11 ++++++-----
 .../files/patch-gtk_intel-lib-freebsd.patch (gone) | 17 -----------------
 4 files changed, 35 insertions(+), 27 deletions(-)
Comment 3 Jon Holman 2024-01-11 09:16:31 UTC
MARKED AS SPAM