Bug 260320 - security/cracklib doesn't have working default dictionary after install
Summary: security/cracklib doesn't have working default dictionary after install
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Cy Schubert
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-12-10 15:09 UTC by dr
Modified: 2022-01-26 23:54 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (cy)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description dr 2021-12-10 15:09:57 UTC 
cracklib-check doesn't work after install on FreeBSD 13.0.
Running cracklib-check will output /usr/local/libdata/cracklib/cracklib-words: error reading header.

The cause seems to be that create-cracklib-dict fails in post-install step because $WORDS_DISTFILE is not downloaded because its not in DISTFILES list.

Can be fixed by adding to Makefile:

DISTFILES=     ${DISTNAME}${EXTRACT_SUFX} ${WORDS_DISTFILE}
EXTRACT_ONLY=  ${DISTNAME}${EXTRACT_SUFX}
Comment 1 Cy Schubert freebsd_committer freebsd_triage 2022-01-26 04:31:06 UTC 
Verified and patched.
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-01-26 06:21:04 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=bab091e20adef82f1a54d53430b8576c55a1759a

commit bab091e20adef82f1a54d53430b8576c55a1759a
Author:     Cy Schubert <cy@FreeBSD.org>
AuthorDate: 2022-01-26 04:28:15 +0000
Commit:     Cy Schubert <cy@FreeBSD.org>
CommitDate: 2022-01-26 06:14:40 +0000

    security/cracklib: Fix error reading header

    Fix incorrectly generated dictionary:
    /usr/local/libdata/cracklib/cracklib-words: error reading header

    PR:             260320
    Submitted by:   dr@loopia.rs
    Reported by:    dr@loopia.rs
    MFH:            2022Q1

 security/cracklib/Makefile | 4 ++++
 1 file changed, 4 insertions(+)
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-01-26 06:22:06 UTC 
A commit in branch 2022Q1 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=7ae43982334b295dc5d5b49ddaebf54ac3f91eb3

commit 7ae43982334b295dc5d5b49ddaebf54ac3f91eb3
Author:     Cy Schubert <cy@FreeBSD.org>
AuthorDate: 2022-01-26 04:28:15 +0000
Commit:     Cy Schubert <cy@FreeBSD.org>
CommitDate: 2022-01-26 06:21:20 +0000

    security/cracklib: Fix error reading header

    Fix incorrectly generated dictionary:
    /usr/local/libdata/cracklib/cracklib-words: error reading header

    PR:             260320
    Submitted by:   dr@loopia.rs
    Reported by:    dr@loopia.rs

    (cherry picked from commit bab091e20adef82f1a54d53430b8576c55a1759a)

 security/cracklib/Makefile | 4 ++++
 1 file changed, 4 insertions(+)
Comment 4 Cy Schubert freebsd_committer freebsd_triage 2022-01-26 23:54:13 UTC 
Fixed